New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 749012 link

Starred by 1 user
Status: Fixed
Owner:
shend@chromium.org
Closed: Jul 2017
Cc:
█ nainar@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

blink_perf.css taking 49 minutes on reference build (was 16 minutes)

Project Member Reported by nedngu...@google.com, Jul 26 2017 
This benchmark is now taking 49 minutes on reference build & 26 minutes on TOT build. In total, this cycle time is too much for a micro benchmark.

See this graph for the cycle time growth:
https://chromeperf.appspot.com/report?sid=a1dc602a0812f1e086f691f15948aeb5f8952d54e8eec77ce55e8bdffcfc559a&rev=487872 

nainar@ is it possible to reduce the cycle time here?

Comment 1 by nedngu...@google.com, Jul 26 2017

Cc: shend@chromium.org
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 26 2017

Labels: Hotlist-Google
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/744f09725b57a1d3e0640c300045946756d0774d

commit 744f09725b57a1d3e0640c300045946756d0774d
Author: Darren Shen <shend@chromium.org>
Date: Thu Jul 27 07:23:08 2017

Reduce blink_perf.css cycle time.

This patch removes a few redundant tests and reduces the size of test
trees for ChangeStyle related tests.

Bug:  749012 
Change-Id: I5beb71a043b745bff53597d37d02fd126b9c3572
Reviewed-on: https://chromium-review.googlesource.com/588208
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489875}
[delete] https://crrev.com/bde597d4a8d370618fa42685dda3e3979b407264/third_party/WebKit/PerformanceTests/CSS/ChangeStyleDeepTree.html
[delete] https://crrev.com/bde597d4a8d370618fa42685dda3e3979b407264/third_party/WebKit/PerformanceTests/CSS/ChangeStyleSinglePseudoSelector.html~HEAD
[delete] https://crrev.com/bde597d4a8d370618fa42685dda3e3979b407264/third_party/WebKit/PerformanceTests/CSS/LoadBootstrapComponents.html
[delete] https://crrev.com/bde597d4a8d370618fa42685dda3e3979b407264/third_party/WebKit/PerformanceTests/CSS/StyleSheetInsert-bootstrap.html
[delete] https://crrev.com/bde597d4a8d370618fa42685dda3e3979b407264/third_party/WebKit/PerformanceTests/CSS/StyleSheetInsert.html
[modify] https://crrev.com/744f09725b57a1d3e0640c300045946756d0774d/third_party/WebKit/PerformanceTests/CSS/resources/utils.js

Comment 4 by shend@chromium.org, Jul 27 2017

Status: Fixed (was: Assigned)
Should be fixed now as the graph has gone back down.

Comment 5 by nedngu...@google.com, Jul 27 2017

Cc: -shend@chromium.org nainar@chromium.org
Owner: shend@chromium.org
The ref build still takes a lot 43 minutes (mean we improve css perf a lot, which is good!). The next thing for us is probably to update the ref build.

Thanks shend!
►

Sign in to add a comment