New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749011 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: Entire text is not selected in the omnibox when chrome://pages are bookmarked and dropped into NTP

Project Member Reported by keerthan...@techmahindra.com, Jul 26 2017

Issue description

Chrome Version:61.0.3163.13
OS:Ubuntu 14.04, Windows

What steps will reproduce the problem?
(1)Launch chrome and bookmark any chrome://pages
(2)Go to NTP and Drag and drop the bookmarked link inside the NTP

Expected:In omnibox, 'about:blank' entire text should be selected
Actual:Instead, cursor is seen at the starting of the text

This is a Regression issue broken in M-61

Manual Bisect Info:
====================
Good Build:61.0.3135.0
Bad Build: 61.0.3136.0

 
CursorActual.ogv
904 KB View Download
CursorExpected.ogv
913 KB View Download
Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.12.6 using latest canary #62.0.3167.0.

Comment 2 by kochi@chromium.org, Jul 26 2017

Components: -Blink>Focus
This is not a Blink focus implementation issue.
Labels: -Needs-Bisect hasbisect-per-revision
Owner: k...@chromium.org
Status: Assigned (was: Untriaged)
Using per revision bisect providing bisect results below

Bisect Information:
--------------------
You are probably looking for a change made after 480449 (known good), but no later than 480450 (first known bad).

Change Log URL: 
-----------------
https://chromium.googlesource.com/chromium/src/+log/9f6fd4b8c8792db8ee6ab1abc8de0b4490e5ff9e..4033a5a4297ace7d7bf93cdc9b8ea35db4fa35da

krb@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!!

Cc: jdonnelly@chromium.org
Labels: -Pri-1 Pri-3
This doesn't strike me as high priority or even something worth fixing at all.

Please let me know if I'm misunderstanding, but here's what I see:

- Dragging bookmarks onto either the omnibox or the content area should navigate to the target of the bookmark.
- Dragging any type of bookmark onto the omnibox does this.
- Dragging a non-chrome:// bookmark onto the content area does this.
- Dragging a chrome:// bookmark onto the content area *does not* do this. (Is there a bug for this?)
- As a workaround for this issue, we instead show about://blank in the omnibox and highlight the text so the user can type something else.

This bug is that the workaround no longer works. But it's a pretty ineffective workaround. Losing it doesn't seem like a problem to me and any effort would be better spent on making the correct navigation happen instead.
Labels: Hotlist-Polish

Comment 6 by k...@chromium.org, Aug 9 2017

Status: Fixed (was: Assigned)
I believe this was fixed with c/572206. Alas, it wasn't approved for 61.

Sign in to add a comment