New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748994 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

browser_tests failing on 2 builders

Project Member Reported by yukishiino@chromium.org, Jul 26 2017

Issue description

browser_tests failing on 2 builders

Builders failed on: 
- Linux Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29
- Linux Tests (dbg)(1)(32): 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29

It seems like that
https://chromium-review.googlesource.com/c/583445/
caused test failures.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1c6f933beebe20d6afce1cc25122164d28aeb1c

commit d1c6f933beebe20d6afce1cc25122164d28aeb1c
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Wed Jul 26 09:11:41 2017

Revert "Add accessibility tests for passwords section of Chrome Settings."

This reverts commit 9c0b1bb3fea8ef2a24480d554555d83a7d387978.

Reason for revert: This seems like causing failures on Linux Tests (dbg) and (dbg) (32).

Original change's description:
> Add accessibility tests for passwords section of Chrome Settings.
> 
> This change includes setting up the GTest and Mocha-based a11y testing framework for Chrome WebUI
> by defining an accessibility_browsertest.js file for a11y test fixtures and including this file in the BUILD.gn.
> 
> The passwords section now fires an event when the settings section has expanded--an event that is responded to in
> the added a11y test.
> 
> Bug: 737739
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: I5eb85b3c1622cfc822dee33d9f6283f87f241201
> Reviewed-on: https://chromium-review.googlesource.com/583445
> Commit-Queue: Tina Quach <quacht@google.com>
> Reviewed-by: Hector Carmona <hcarmona@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#489520}

TBR=aboxhall@chromium.org,tommycli@chromium.org,hcarmona@chromium.org,quacht@google.com

Change-Id: Id2dcdb60a0356a8f56ec575f21a715748ec3f664
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 737739,  748994 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/586087
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489569}
[modify] https://crrev.com/d1c6f933beebe20d6afce1cc25122164d28aeb1c/chrome/browser/resources/settings/settings_page/settings_section.js
[modify] https://crrev.com/d1c6f933beebe20d6afce1cc25122164d28aeb1c/chrome/test/data/webui/BUILD.gn
[delete] https://crrev.com/983299c943a4ba6eec819c91ff6f6b429df4e90a/chrome/test/data/webui/settings/accessibility_browsertest.js
[delete] https://crrev.com/983299c943a4ba6eec819c91ff6f6b429df4e90a/chrome/test/data/webui/settings/passwords_a11y_test.js

A revert is on-going at:
https://chromium-review.googlesource.com/c/586087

Comment 3 by meade@chromium.org, Jul 28 2017

Status: Fixed (was: Available)
Seems fixed.

Sign in to add a comment