New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748984 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:'Google Chrome OS terms' page is displayed twice, when we click back button in that page

Project Member Reported by rkalavakuntla@chromium.org, Jul 26 2017

Issue description

Chrome Version:60.0.3112.78/9592.68.0 Beta channel Daisy,Candy,Minnie
OS:chrome

What steps will reproduce the problem?
(1)Recover Build -> Go to 'Connect to Network' page and Connect to a network
(2)After network connected,'Google Chrome OS terms' page appears >> Click on back button in that page and now again click on connected network in 'Connect to Network' page
(3)Repeat the step (2) for 3-4 times and Observe(Kindly refer screen-cast)

Actual:Clicking on Back button of 'Google Chrome OS terms'page,navigates to same page i.e; 'Google Chrome OS terms' page is displayed again twice
Expected:Clicking on Back button of 'Google Chrome OS terms' should navigate to 'Connect to Network' page

This is a Regression issue as same is working fine in 57.0.2987.154/9202.71.0 stable channel Candy

Note:
1.Issue is also seen in latest dev M-62
2.Issue is not applicable for Linux,Windows OS

@alemate: could you please confirm the above issue
 
Actual.mp4
18.9 MB Download
Expected.mp4
3.9 MB View Download
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6fc374893ce4c42f60692f3ad0e58eb0ef20c53

commit d6fc374893ce4c42f60692f3ad0e58eb0ef20c53
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 09 01:42:49 2017

ChromeOS OOBE: Make EULA Back button work correctly.

This Cl prevents running reconnect on already connected network item.

Bug:  748984 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia695e0adaded02707d2ad4d148cd5eee5042ec52
Reviewed-on: https://chromium-review.googlesource.com/604382
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492803}
[modify] https://crrev.com/d6fc374893ce4c42f60692f3ad0e58eb0ef20c53/chrome/browser/resources/chromeos/login/oobe_welcome.js

Labels: -M-62 M-61 Merge-Request-61
Status: Fixed (was: Started)
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 9 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3697c0df41da504b2c796ea9f841027ab00307b7

commit 3697c0df41da504b2c796ea9f841027ab00307b7
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 09 23:14:36 2017

ChromeOS OOBE: Make EULA Back button work correctly.

This Cl prevents running reconnect on already connected network item.

TBR=alemate@chromium.org

(cherry picked from commit d6fc374893ce4c42f60692f3ad0e58eb0ef20c53)

Bug:  748984 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia695e0adaded02707d2ad4d148cd5eee5042ec52
Reviewed-on: https://chromium-review.googlesource.com/604382
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492803}
Reviewed-on: https://chromium-review.googlesource.com/609446
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#414}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/3697c0df41da504b2c796ea9f841027ab00307b7/chrome/browser/resources/chromeos/login/oobe_welcome.js

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment