New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748879 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 750893
issue 724708



Sign in to add a comment

EasyUnlock v2: Implement ProximityAuthLocalStatePrefManager

Project Member Reported by tengs@chromium.org, Jul 26 2017

Issue description

This manager will handle getting prefs from the local state when the user is not logged in.
 

Comment 1 by tengs@chromium.org, Jul 31 2017

Blocking: 750893
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/947837858fe1b396546b30ecb59569239af09d09

commit 947837858fe1b396546b30ecb59569239af09d09
Author: Tim Song <tengs@chromium.org>
Date: Tue Aug 01 20:44:09 2017

[EasyUnlock] Add ProximityAuthLocalStatePrefManager for managing prefs before login.

This CL also refactors ProximityAuthProfilePRefManager to handle the syncing of
profile prefs to local state.

BUG= 748879 

Change-Id: Ia09a772b10b7b3e2305153c52b1457101cd950c5
Reviewed-on: https://chromium-review.googlesource.com/585899
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491102}
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/chrome/browser/signin/chrome_proximity_auth_client.cc
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/chrome/browser/signin/chrome_proximity_auth_client.h
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/chrome/browser/signin/easy_unlock_service.cc
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/chrome/browser/signin/easy_unlock_service.h
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/chrome/browser/signin/easy_unlock_service_regular.h
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/chrome/browser/signin/easy_unlock_service_signin_chromeos.h
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/chrome/common/pref_names.cc
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/chrome/common/pref_names.h
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/mock_proximity_auth_client.h
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/proximity_auth_client.h
[add] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/proximity_auth_local_state_pref_manager.cc
[add] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/proximity_auth_local_state_pref_manager.h
[add] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/proximity_auth_local_state_pref_manager_unittest.cc
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/proximity_auth_pref_manager.h
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/proximity_auth_pref_names.cc
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/proximity_auth_pref_names.h
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/proximity_auth_profile_pref_manager.cc
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/proximity_auth_profile_pref_manager.h
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/proximity_auth_profile_pref_manager_unittest.cc
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/proximity_auth_system.cc
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/proximity_auth_system.h
[modify] https://crrev.com/947837858fe1b396546b30ecb59569239af09d09/components/proximity_auth/proximity_auth_system_unittest.cc

Comment 3 by tengs@chromium.org, Aug 1 2017

Labels: M-61 Merge-Request-61

Comment 4 by tengs@chromium.org, Aug 1 2017

Cc: sacomoto@chromium.org
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 7 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 7 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08dcb9fd8fd385262fd9044a5481d4d3880590ef

commit 08dcb9fd8fd385262fd9044a5481d4d3880590ef
Author: Tim Song <tengs@chromium.org>
Date: Mon Aug 07 18:37:30 2017

[EasyUnlock] Add ProximityAuthLocalStatePrefManager for managing prefs before login.

This CL also refactors ProximityAuthProfilePRefManager to handle the syncing of
profile prefs to local state.

BUG= 748879 
TBR=tengs@chromium.org

(cherry picked from commit 947837858fe1b396546b30ecb59569239af09d09)

Change-Id: Ia09a772b10b7b3e2305153c52b1457101cd950c5
Reviewed-on: https://chromium-review.googlesource.com/585899
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491102}
Reviewed-on: https://chromium-review.googlesource.com/604212
Cr-Commit-Position: refs/branch-heads/3163@{#362}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/chrome/browser/signin/chrome_proximity_auth_client.cc
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/chrome/browser/signin/chrome_proximity_auth_client.h
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/chrome/browser/signin/easy_unlock_service.cc
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/chrome/browser/signin/easy_unlock_service.h
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/chrome/browser/signin/easy_unlock_service_regular.h
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/chrome/browser/signin/easy_unlock_service_signin_chromeos.h
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/chrome/common/pref_names.cc
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/chrome/common/pref_names.h
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/mock_proximity_auth_client.h
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/proximity_auth_client.h
[add] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/proximity_auth_local_state_pref_manager.cc
[add] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/proximity_auth_local_state_pref_manager.h
[add] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/proximity_auth_local_state_pref_manager_unittest.cc
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/proximity_auth_pref_manager.h
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/proximity_auth_pref_names.cc
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/proximity_auth_pref_names.h
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/proximity_auth_profile_pref_manager.cc
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/proximity_auth_profile_pref_manager.h
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/proximity_auth_profile_pref_manager_unittest.cc
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/proximity_auth_system.cc
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/proximity_auth_system.h
[modify] https://crrev.com/08dcb9fd8fd385262fd9044a5481d4d3880590ef/components/proximity_auth/proximity_auth_system_unittest.cc

Comment 8 by tengs@chromium.org, Aug 7 2017

Status: Fixed (was: Assigned)

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment