New issue
Advanced search Search tips

Issue 748851 link

Starred by 1 user
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Sep 2017
Cc:
yfried...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

gn gen has become slow on Android

Project Member Reported by agrieve@chromium.org, Jul 26 2017 
Taking ~ 4 seconds on my machine. A year ago it was < 2 seconds.

I took a trace via:
gn gen . --tracelog=gn.trace

And found that the largest bottleneck is:
//third_party/android_tools/BUILD.gn

Each call to build/android/gyp/aar.py --list is done serially, and the entire file took 1.4 seconds to evaluate.

Comment 1 by agrieve@chromium.org, Jul 28 2017 

Note: Tried adding in a cache to aar.py --list, but it didn't get any faster. The slow part must be executing python in the first place. Thus, we can make the build faster by:

a) Splitting up the slow BUILD.gn into multiple files, or
b) Change android_aar_prebuilt such that the result of aar.py --list must be checked into the codebase.

Leaning towards b.

Comment 2 by agrieve@chromium.org, Aug 9 2017 

An extended proposal for b):

* Add a boolean to android_aar_prebuilt(): use_cached_info = true
* Skip exec_script() when boolean is true, Use read_file() on "foo.aar.info" instead
* Upon extraction step, validate that "foo.aar.info" is up-to-date (to ensure .aar is not updated without .info not being updated)
* Add a GN arg: update_aar_prebuilt_info = true. When set, use exec_script to write new .aar.info files.

Depending on how many .aar files we have, we might want to skip the per-target flag and just make all files use this mechanism.

Comment 3 by agrieve@chromium.org, Aug 10 2017 

Trace also shows these targets to take up 150ms:
//third_party/WebKit/Source/bindings/modules/v8:bindings_modules_impl
//third_party/WebKit/Source/bindings/core/v8:bindings_core_impl

Not sure why they are slow though...
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d04b06a98e44e072075b11777984d67a2e9b3099

commit d04b06a98e44e072075b11777984d67a2e9b3099
Author: Andrew Grieve <agrieve@chromium.org>
Date: Thu Aug 10 16:54:08 2017

Speed up "gn gen" by ~65ms for non-mac host_os

By skipping an xcode-specific exec_script().
Discovered via "gn gen --tracelog=gn.trace"

Bug:  748851 
Change-Id: I7d7d1f636e90d4842758d94a1b327622bb9f5edc
Reviewed-on: https://chromium-review.googlesource.com/609163
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493431}
[modify] https://crrev.com/d04b06a98e44e072075b11777984d67a2e9b3099/build_overrides/build.gni
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5302e35e0230a5661f081732b621241cfa00c4bf

commit 5302e35e0230a5661f081732b621241cfa00c4bf
Author: Andrew Grieve <agrieve@chromium.org>
Date: Mon Aug 28 19:59:51 2017

Android: Cache exec_script() output for android_aar_prebuilt() targets

Speeds up "gn gen" by about 600ms on my machine.

BUG= 748851 

Change-Id: I2a4208728eddc49bab040459e9b93552d0a9cc55
Reviewed-on: https://chromium-review.googlesource.com/609147
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497853}
[modify] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/android/gyp/aar.py
[modify] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/config/android/config.gni
[modify] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/config/android/rules.gni
[modify] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/BUILD.gn
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_compat_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_core_ui_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_core_utils_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_design_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_fragment_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_media_compat_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_multidex_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_transition_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_v13_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_v14_preference_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_v17_leanback_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_v17_preference_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_v7_appcompat_java_internal.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_v7_gridlayout_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_v7_mediarouter_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_v7_palette_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_v7_preference_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_v7_recyclerview_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/android_support_vector_drawable_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/google_play_services_auth_base_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/google_play_services_auth_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/google_play_services_base_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/google_play_services_basement_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/google_play_services_cast_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/google_play_services_gcm_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/google_play_services_iid_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/google_play_services_location_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/google_play_services_nearby_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/google_play_services_tasks_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/build/secondary/third_party/android_tools/google_play_services_vision_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/third_party/android_support_test_runner/rules_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/third_party/gvr-android-sdk/controller_test_api_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/third_party/gvr-android-sdk/gvr_common_java.info
[add] https://crrev.com/5302e35e0230a5661f081732b621241cfa00c4bf/third_party/gvr-android-sdk/gvr_controller_java.info
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03ac069ca8de6a9b92572fadd73f79f794f129ab

commit 03ac069ca8de6a9b92572fadd73f79f794f129ab
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Aug 29 01:12:15 2017

Revert "Android: Cache exec_script() output for android_aar_prebuilt() targets"

This reverts commit 5302e35e0230a5661f081732b621241cfa00c4bf.

Reason for revert: Breaks downstream bots

Original change's description:
> Android: Cache exec_script() output for android_aar_prebuilt() targets
> 
> Speeds up "gn gen" by about 600ms on my machine.
> 
> BUG= 748851 
> 
> Change-Id: I2a4208728eddc49bab040459e9b93552d0a9cc55
> Reviewed-on: https://chromium-review.googlesource.com/609147
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Biao She <bshe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497853}

TBR=bshe@chromium.org,mikecase@chromium.org,agrieve@chromium.org,jbudorick@chromium.org

Change-Id: I1a0b64611d619be6252d19b80d373fb9984e9ee9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  748851 , 759903
Reviewed-on: https://chromium-review.googlesource.com/640110
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497970}
[modify] https://crrev.com/03ac069ca8de6a9b92572fadd73f79f794f129ab/build/android/gyp/aar.py
[modify] https://crrev.com/03ac069ca8de6a9b92572fadd73f79f794f129ab/build/config/android/config.gni
[modify] https://crrev.com/03ac069ca8de6a9b92572fadd73f79f794f129ab/build/config/android/rules.gni
[modify] https://crrev.com/03ac069ca8de6a9b92572fadd73f79f794f129ab/build/secondary/third_party/android_tools/BUILD.gn
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_compat_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_core_ui_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_core_utils_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_design_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_fragment_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_media_compat_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_multidex_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_transition_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_v13_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_v14_preference_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_v17_leanback_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_v17_preference_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_v7_appcompat_java_internal.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_v7_gridlayout_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_v7_mediarouter_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_v7_palette_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_v7_preference_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_v7_recyclerview_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/android_support_vector_drawable_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/google_play_services_auth_base_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/google_play_services_auth_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/google_play_services_base_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/google_play_services_basement_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/google_play_services_cast_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/google_play_services_gcm_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/google_play_services_iid_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/google_play_services_location_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/google_play_services_nearby_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/google_play_services_tasks_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/build/secondary/third_party/android_tools/google_play_services_vision_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/third_party/android_support_test_runner/rules_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/third_party/gvr-android-sdk/controller_test_api_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/third_party/gvr-android-sdk/gvr_common_java.info
[delete] https://crrev.com/b046099adcfa1192152a02d8106340a71bdb87b0/third_party/gvr-android-sdk/gvr_controller_java.info
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 29 2017

Labels: merge-merged-3199
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b274b9c13732623c481c542556bb5a4e1acbb96a

commit b274b9c13732623c481c542556bb5a4e1acbb96a
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Aug 29 08:10:51 2017

Revert "Android: Cache exec_script() output for android_aar_prebuilt() targets"

This reverts commit 5302e35e0230a5661f081732b621241cfa00c4bf.

Reason for revert: Breaks downstream bots

Original change's description:
> Android: Cache exec_script() output for android_aar_prebuilt() targets
>
> Speeds up "gn gen" by about 600ms on my machine.
>
> BUG= 748851 
>
> Change-Id: I2a4208728eddc49bab040459e9b93552d0a9cc55
> Reviewed-on: https://chromium-review.googlesource.com/609147
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Biao She <bshe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497853}

TBR=agrieve@chromium.org, bshe@chromium.org, jbudorick@chromium.org, mikecase@chromium.org

(cherry picked from commit 03ac069ca8de6a9b92572fadd73f79f794f129ab)

Change-Id: I1a0b64611d619be6252d19b80d373fb9984e9ee9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  748851 , 759903
Reviewed-on: https://chromium-review.googlesource.com/640110
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497970}
Reviewed-on: https://chromium-review.googlesource.com/640394
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3199@{#3}
Cr-Branched-From: d5e0252247308646430a8ad488ffeb9005f1a653-refs/heads/master@{#497962}
[modify] https://crrev.com/b274b9c13732623c481c542556bb5a4e1acbb96a/build/android/gyp/aar.py
[modify] https://crrev.com/b274b9c13732623c481c542556bb5a4e1acbb96a/build/config/android/config.gni
[modify] https://crrev.com/b274b9c13732623c481c542556bb5a4e1acbb96a/build/config/android/rules.gni
[modify] https://crrev.com/b274b9c13732623c481c542556bb5a4e1acbb96a/build/secondary/third_party/android_tools/BUILD.gn
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_compat_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_core_ui_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_core_utils_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_design_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_fragment_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_media_compat_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_multidex_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_transition_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_v13_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_v14_preference_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_v17_leanback_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_v17_preference_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_v7_appcompat_java_internal.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_v7_gridlayout_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_v7_mediarouter_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_v7_palette_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_v7_preference_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_v7_recyclerview_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/android_support_vector_drawable_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/google_play_services_auth_base_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/google_play_services_auth_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/google_play_services_base_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/google_play_services_basement_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/google_play_services_cast_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/google_play_services_gcm_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/google_play_services_iid_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/google_play_services_location_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/google_play_services_nearby_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/google_play_services_tasks_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/build/secondary/third_party/android_tools/google_play_services_vision_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/third_party/android_support_test_runner/rules_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/third_party/gvr-android-sdk/controller_test_api_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/third_party/gvr-android-sdk/gvr_common_java.info
[delete] https://crrev.com/f8f22a4f9f3e34c4c7d64ddd82055f7f5abac494/third_party/gvr-android-sdk/gvr_controller_java.info
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 29 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/ebffe4c79f8c5b4ae5bb9ac9ab232de6786f7621

commit ebffe4c79f8c5b4ae5bb9ac9ab232de6786f7621
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Aug 29 17:30:35 2017
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf7f522954566498f01a4809932319b720e57338

commit cf7f522954566498f01a4809932319b720e57338
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Aug 29 20:28:07 2017

Reland: Android: Cache exec_script() output for android_aar_prebuilt() targets

This reverts commit 03ac069ca8de6a9b92572fadd73f79f794f129ab.

Reason for reland: Reworked support .aars to work with downstream

Speeds up "gn gen" by about 600ms on my machine.

NOTRY=true (all passed except net_unittests, which is globally broken atm)
TBR=bshe@chromium.org

Bug:  748851 , 759903
Change-Id: I639aeb64ef2f531589e8c04535d48a54e413fe15
Reviewed-on: https://chromium-review.googlesource.com/641371
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498216}
[modify] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/android/gyp/aar.py
[modify] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/config/android/config.gni
[modify] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/config/android/rules.gni
[modify] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/BUILD.gn
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/google_play_services_auth_base_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/google_play_services_auth_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/google_play_services_base_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/google_play_services_basement_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/google_play_services_cast_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/google_play_services_gcm_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/google_play_services_iid_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/google_play_services_location_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/google_play_services_nearby_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/google_play_services_tasks_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/google_play_services_vision_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/BUILD.gn
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_compat_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_core_ui_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_core_utils_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_design_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_fragment_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_media_compat_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_multidex_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_transition_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_v13_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_v14_preference_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_v17_leanback_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_v17_preference_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_v7_appcompat_java_internal.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_v7_gridlayout_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_v7_mediarouter_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_v7_palette_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_v7_preference_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_v7_recyclerview_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/build/secondary/third_party/android_tools/support/android_support_vector_drawable_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/third_party/android_support_test_runner/rules_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/third_party/gvr-android-sdk/controller_test_api_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/third_party/gvr-android-sdk/gvr_common_java.info
[add] https://crrev.com/cf7f522954566498f01a4809932319b720e57338/third_party/gvr-android-sdk/gvr_controller_java.info
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b25606eda9017a63970326eca5f0c227db157a3a

commit b25606eda9017a63970326eca5f0c227db157a3a
Author: Andrew Grieve <agrieve@chromium.org>
Date: Wed Aug 30 18:23:44 2017

Android: Add comment for when android_aar_prebuilt() .info is missing

NOTRY=true  # Comment-only change

Bug:  748851 
Change-Id: Idf1901d02a7844abbe47f4cabf221f14e87c86e7
Reviewed-on: https://chromium-review.googlesource.com/641380
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498539}
[modify] https://crrev.com/b25606eda9017a63970326eca5f0c227db157a3a/build/config/android/rules.gni

Comment 11 by agrieve@chromium.org, Sep 8 2017

Status: Fixed (was: Available)
It's definitely still slower than it used to be, but I've fixed the two low-hanging fruits, so closing.
►

Sign in to add a comment