New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748849 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 680790
issue 688629
issue 748850



Sign in to add a comment

Implement reporting for onSafeBrowsingHit (backToSafety/proceed)

Project Member Reported by ntfschr@chromium.org, Jul 26 2017

Issue description

As part of WebViewClient#onSafeBrowsingHit, we offer applications a way to choose whether or not to report Safe Browsing hits using the Safe Browsing reporting mechanism Tim has been working on.

Specifically, the API looks like:

    public abstract void proceed(boolean report);
    public abstract void backToSafety(boolean report);

`backToSafety(true)` should send a report just as if the user checked the checkbox and clicked "back to safety" themselves. Currently the reporting part of these actions is left unimplemented [1].

Tim and Jialiu, what's the best way to invoke the reporting sequence from here? In these situations, we'll have a ResourceThrottle and UIManager, but we'll skip the BlockingPage entirely.

Tentatively assigning to Tim, but I'm not opposed to implementing if someone can walk me through the correct entry point for creating & sending a report.

[1] https://cs.chromium.org/chromium/src/android_webview/browser/aw_safe_browsing_resource_throttle.cc?type=cs&q=f:android_webview+f:safe_browsing+crbug&sq=package:chromium&l=108
 
Components: UI>Browser>SafeBrowsing Mobile>WebView
Blocking: 748850
Cc: ntfschr@chromium.org
Labels: M-62
Adding milestone, since we shouldn't leave this broken for too long.
Labels: WebView-SafeBrowsing

Comment 5 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 6 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt
Labels: -Pri-2 -M-62 Pri-3
Lowering priority and removing milestone (but, Safe Browsing team should readjust priority as appropriate).
Blocking:

Sign in to add a comment