New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748828 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 730832


Participants' hotlists:
luci-config-ui


Sign in to add a comment

Feedback button links to bug template with private hotlist "luci-config"

Project Member Reported by dsansome@chromium.org, Jul 26 2017

Issue description

When I click the feedback button and submit the issue in Monorail it silently fails.  The error message is hidden inside the "More options" link:

You have no hotlist(s) named: luci-config

https://screenshot.googleplex.com/XwLcnhdTqX3

You probably need to remove the "hotlists=luci-config" URL query parameter, or make the hotlist public?
 
I think it's best to remove the hotlist from the template. There is a publicly readable luci-config-ui hotlist, but I wouldn't want it to be publicly writable.

Comment 2 by cwpayton@google.com, Jul 26 2017

Owner: cwpayton@google.com
Status: Started (was: Untriaged)

Comment 3 by no...@chromium.org, Jul 26 2017

Labels: Pri-1 Type-Bug
I hit this too today and could not figure out what's wrong.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/b814755395f4379d6e95f06223edd8b135f46591

commit b814755395f4379d6e95f06223edd8b135f46591
Author: cwpayton <cwpayton@google.com>
Date: Wed Jul 26 18:38:06 2017

config_service: Removed hotlist from feedback link.

Since our hotlist is not publicly writable, we need to remove the hotlist
from the feedback link

BUG= 748828 

Review-Url: https://codereview.chromium.org/2985903002

[modify] https://crrev.com/b814755395f4379d6e95f06223edd8b135f46591/appengine/config_service/ui/static/index.html

Comment 5 by cwpayton@google.com, Jul 26 2017

Status: Fixed (was: Started)

Comment 6 by no...@chromium.org, Jul 28 2017

Status: Verified (was: Fixed)

Sign in to add a comment