New issue
Advanced search Search tips

Issue 748769 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 768247
Owner: ----
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

crosh: TERM hardcoded to 'xterm', causing 256-color mode disabled

Reported by dancec...@gmail.com, Jul 26 2017

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 9460.73.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.134 Safari/537.36
Platform: 9460.73.1 (Official Build) stable-channel terra

Steps to reproduce the problem:
1. Install the Chrome OS developer shell
2. Open the shell
3. Open preferences via CTRL+SHIFT+P
4. Open a Javascript developer console and enter:
   > term_.prefs_.get('environment')
5. See that the default for TERM is xterm-256color
6. Go back to the shell and type "shell"
7. Check the TERM value
   > echo $TERM
8. Check the number of colors
   > tput colors

What is the expected behavior?
TERM should be set according to preferences (i.e. xterm-256color by default)

Number of colors should be 256 by default

What went wrong?
TERM is set to 'xterm', disabling 256-color mode

Because TERM=xterm, the number of colors is 8

Did this work before? No 

Chrome version: 59.0.3071.134  Channel: stable
OS Version: 9460.73.1
Flash Version: 

This seems to have been caused by  Issue 220405 
- code review: https://chromiumcodereview.appspot.com/12223118/patch/8001/9001
- current code: https://cs.chromium.org/chromium/src/chromeos/process_proxy/process_proxy.cc?l=219
> options.environ["TERM"] = "xterm";
 
Components: -Platform>DevTools Infra>Client>ChromeOS

Comment 2 by vapier@chromium.org, Oct 24 2017

Components: -Infra>Client>ChromeOS Platform>Apps>Default>Hterm
Mergedinto: 768247
Status: Duplicate (was: Unconfirmed)
Summary: crosh: TERM hardcoded to 'xterm', causing 256-color mode disabled (was: hterm: TERM hardcoded to 'xterm', causing 256-color mode disabled)
sorry, duplicating to a newer bug as no one noticed this due to misfiling

Comment 3 by dancec...@gmail.com, Oct 24 2017

Thanks for refiling the issue for me! (I'm not sure if it was something I missed, but I seem to remember having trouble selecting the Hterm category through the wizard...)

Comment 4 by vapier@chromium.org, Oct 24 2017

you can use this shortcut in the future:
  https://goo.gl/vb94JY

Comment 5 by dancec...@gmail.com, Oct 24 2017

Cool, thanks :)

Sign in to add a comment