New issue
Advanced search Search tips

Issue 748768 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Capture region mode doesn't deactivate palette tray when finished.

Project Member Reported by sammiequon@chromium.org, Jul 26 2017

Issue description

(1) Open palette tray, select capture region mode.
(2) Palette tray is active.
(3) Select a region with stylus, capture region mode should end.
(4) Palette tray icon is default, but is still active.

 
Components: UI>Input
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/775459159e1ef4b562323864f33ad807c71afc0d

commit 775459159e1ef4b562323864f33ad807c71afc0d
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Jul 26 19:42:35 2017

cros: Capture region tool doesn't deactivate palette tray.

This mode automatically turns off after the screenshot is taken so it can get deactivated in addition to clicking the palette tray. Deactivate when the active tool changes to handle such cases.

Test: ash_unittests gtest_filter="PaletteTrayTest.ModeToolDeactivatedAutomatically"
Bug:  748768 
Change-Id: Ife35372871e7b293095dffbe8a9244292a3ca5c4
Reviewed-on: https://chromium-review.googlesource.com/586670
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489728}
[modify] https://crrev.com/775459159e1ef4b562323864f33ad807c71afc0d/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/775459159e1ef4b562323864f33ad807c71afc0d/ash/system/palette/palette_tray_unittest.cc

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment