DCHECK_CURRENTLY_ON misleading in test_browser_thread_bundle_unittest.cc |
|
Issue descriptionVersion: 62.0.3167.0 DCHECK_CURRENTLY_ON will succeed for any thread label when run with TestBrowserThreadBundle with no additional threads because TestBrowserThreadBundle runs everything in one thread and MessageLoop. I'm not sure how the interaction between ScopedTaskEnvironment and TestBrowserThreadBundle works but changing the DCHECK to the IO thread in the ScopedTaskEnvironmentAndTestBrowserThreadBundle test will still pass unless TestBrowserThreadBundle is constructed with REAL_IO_THREAD. |
|
►
Sign in to add a comment |
|
Comment 1 by benhenry@google.com
, Jan 10