New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748765 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK_CURRENTLY_ON misleading in test_browser_thread_bundle_unittest.cc

Project Member Reported by btolsch@chromium.org, Jul 26 2017

Issue description

Version: 62.0.3167.0

DCHECK_CURRENTLY_ON will succeed for any thread label when run with TestBrowserThreadBundle with no additional threads because TestBrowserThreadBundle runs everything in one thread and MessageLoop.

I'm not sure how the interaction between ScopedTaskEnvironment and TestBrowserThreadBundle works but changing the DCHECK to the IO thread in the ScopedTaskEnvironmentAndTestBrowserThreadBundle test will still pass unless TestBrowserThreadBundle is constructed with REAL_IO_THREAD.
 
Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment