DCHECK_CURRENTLY_ON misleading in audio_input_renderer_host_unittest.cc |
||
Issue descriptionVersion: 62.0.3167.0 DCHECK_CURRENTLY_ON will succeed for any thread label when run with TestBrowserThreadBundle with no additional threads because TestBrowserThreadBundle runs everything in one thread and MessageLoop.
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/937fd0b3c4e68a632ce78202e62e945634583019 commit 937fd0b3c4e68a632ce78202e62e945634583019 Author: Max Morin <maxmorin@chromium.org> Date: Wed Aug 09 08:11:51 2017 Remove thread check in AudioInputRendererHost test The AudioInputRendererHost test is single threaded, so the check doesn't actually do anything. BUG= 748762 Change-Id: I752b8d927bc067e7f6c57a4bb02951c64032b1f4 Reviewed-on: https://chromium-review.googlesource.com/605608 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#492898} [modify] https://crrev.com/937fd0b3c4e68a632ce78202e62e945634583019/content/browser/renderer_host/media/audio_input_renderer_host_unittest.cc
,
Aug 9 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by guidou@chromium.org
, Aug 2 2017Owner: maxmorin@chromium.org
Status: Assigned (was: Untriaged)