New issue
Advanced search Search tips

Issue 748759 link

Starred by 1 user
Status: WontFix
Owner:
m...@chromium.org
Closed: Aug 2017
Cc:
guidou@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK_CURRENTLY_ON misleading in web_contents_video_capture_device_unittest.cc

Project Member Reported by btolsch@chromium.org, Jul 25 2017 
Version: 62.0.3167.0

DCHECK_CURRENTLY_ON will succeed for any thread label when run with TestBrowserThreadBundle with no additional threads because TestBrowserThreadBundle runs everything in one thread and MessageLoop.

Comment 1 by guidou@chromium.org, Aug 2 2017

Owner: m...@chromium.org
Status: Assigned (was: Untriaged)
miu@: Can you take a look or triage further?

Comment 2 by m...@chromium.org, Aug 3 2017

Status: WontFix (was: Assigned)
I'm not sure that it's misleading: The code on line 545 assumes that the current task runner is the one associated with BrowserThread::UI because it wants to block the current task runner while running a nested run loop. Regardless of what thread we're on, it's the event loop in the current call stack that matters.

Worst case scenario is that the DCHECKs have no effect, but are at least documentative. ;-)

Feel free to re-open if you disagree, or there's something I'm missing here.
►

Sign in to add a comment