New issue
Advanced search Search tips

Issue 748750 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Tray icons for some stylus tools are inverted

Project Member Reported by kaznacheev@chromium.org, Jul 25 2017

Issue description

Specifically:
Assistant (both x2 and x1 size)
Laser pointer (x2 size only)

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9191b87bd02343147139fb3f3e320d8bec5b8999

commit 9191b87bd02343147139fb3f3e320d8bec5b8999
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Thu Jul 27 17:07:55 2017

Fix inverted tray icons for stylus tools

Remove ROUND_RECT from metalayer icons.
Copy the structure from the 1x laser pointer icon
to the 2x version.

Bug:  748750 
Change-Id: Id6fba141a0a3fa9610cafe92fc4818ede0982399
Reviewed-on: https://chromium-review.googlesource.com/585643
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489988}
[modify] https://crrev.com/9191b87bd02343147139fb3f3e320d8bec5b8999/ash/resources/vector_icons/palette_tray_icon_laser_pointer.icon
[modify] https://crrev.com/9191b87bd02343147139fb3f3e320d8bec5b8999/ash/resources/vector_icons/palette_tray_icon_metalayer.1x.icon
[modify] https://crrev.com/9191b87bd02343147139fb3f3e320d8bec5b8999/ash/resources/vector_icons/palette_tray_icon_metalayer.icon

Status: Fixed (was: Assigned)
Issue 749794 has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 3 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f2fd571c4c0ded36035a5a0a18dc9b1e5552c53

commit 5f2fd571c4c0ded36035a5a0a18dc9b1e5552c53
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Thu Aug 03 00:52:28 2017

Fix inverted tray icons for stylus tools

Remove ROUND_RECT from metalayer icons.
Copy the structure from the 1x laser pointer icon
to the 2x version.

TBR=kaznacheev@google.com

(cherry picked from commit 9191b87bd02343147139fb3f3e320d8bec5b8999)

Bug:  748750 
Change-Id: Id6fba141a0a3fa9610cafe92fc4818ede0982399
Reviewed-on: https://chromium-review.googlesource.com/585643
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489988}
Reviewed-on: https://chromium-review.googlesource.com/599408
Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#257}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/5f2fd571c4c0ded36035a5a0a18dc9b1e5552c53/ash/resources/vector_icons/palette_tray_icon_laser_pointer.icon
[modify] https://crrev.com/5f2fd571c4c0ded36035a5a0a18dc9b1e5552c53/ash/resources/vector_icons/palette_tray_icon_metalayer.1x.icon
[modify] https://crrev.com/5f2fd571c4c0ded36035a5a0a18dc9b1e5552c53/ash/resources/vector_icons/palette_tray_icon_metalayer.icon

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment