Disable MainViewControllerTest.StatusBar on iOS11 |
||||||||
Issue descriptionDisables MainViewControllerTest StatusBar on iOS11, which appears to have started failing on beta 4 (but not beta 3). marq@ this test only fails when run with all of ios_chrome_unittests, not when run individually. Any ideas? Marking ReleaseBlock-Beta but perhaps that can be removed.
,
Jul 31 2017
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 31 2017
,
Aug 25 2017
This will block our M62 beta soon. Any update here?
,
Aug 28 2017
liaoyuke@ can you take a look while marq@ is out?
,
Aug 31 2017
Marq@ please take a look at this test. We are branching today.
,
Sep 1 2017
,
Sep 1 2017
This doesn't repro (that is, the test works fine) in simulator on Xcode 9 beta 6.
,
Sep 1 2017
Still failing on the (beta 4) trybots, but fixed on beta 6. This CL reenables the test: https://chromium-review.googlesource.com/c/chromium/src/+/647746 RBB -> RBS, since the bots are expected to be updated to beta 6 or beyond well before release. Assigning to justincohen@ to land the CL once the bots are updated.
,
Sep 6 2017
justincohen@ please what's the status on this blocker? We aim to fix our blockers as early in the cycle as possible.
,
Sep 7 2017
cmasso@ bots will be updated when GM comes out, presumably next week.
,
Sep 7 2017
Alright, thanks!
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16f337c5a15ad5d04b8e1db3e273468e0957fa53 commit 16f337c5a15ad5d04b8e1db3e273468e0957fa53 Author: Mark Cogan <marq@google.com> Date: Wed Sep 13 13:36:14 2017 Restore MainViewControllerTest.StatusBar for iOS11 This test, disabled because it fails in iOS 11b3 and b4, works correctly under beta 6. This CL can be landed when beta 6 is on the trybots. Bug: 748738 Change-Id: I514eaa8dc104bff6f38b13bff2f541e18edbddbf Reviewed-on: https://chromium-review.googlesource.com/647746 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501611} [modify] https://crrev.com/16f337c5a15ad5d04b8e1db3e273468e0957fa53/ios/chrome/browser/ui/main/main_view_controller_unittest.mm
,
Sep 13 2017
Removing release block, this does not need to go on the branch (just re-enabling a test due to infrastructure updates)
,
Sep 13 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-62; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-62 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 13 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 26 2017