Console pretty prints a single empty element as "empty x 1" |
||
Issue descriptionThis is really minor, but typing expression "[1,,2]" in console outputs [1, empty x 1, 2] IMHO, this is not tidy. it should simply print "empty", without the multiplicator
,
Jul 26 2017
Could I fix this issue to get acquainted with the contribution process for DevTools? I've already made the fix in a local branch.
,
Jul 26 2017
Here is my CL to fix this bug: https://chromium-review.googlesource.com/c/586227/
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f32a30eecec0bc4702ce20fb36ed704f94a42270 commit f32a30eecec0bc4702ce20fb36ed704f94a42270 Author: Nathanael Alcock <varkor@google.com> Date: Thu Jul 27 23:33:34 2017 DevTools: Pretty print single empty array element without a quantity When pretty-printing an array in the console, if there is a single empty element only, it is no longer displayed with ' × 1' appended. Bug:748729. Change-Id: I22013662f9e49786dbf3570c5a40794db8cd2bf5 Reviewed-on: https://chromium-review.googlesource.com/586227 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#490106} [modify] https://crrev.com/f32a30eecec0bc4702ce20fb36ed704f94a42270/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-array-prototype-expected.txt [modify] https://crrev.com/f32a30eecec0bc4702ce20fb36ed704f94a42270/third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt [modify] https://crrev.com/f32a30eecec0bc4702ce20fb36ed704f94a42270/third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js
,
Jul 27 2017
Thank you for your patch! Marking as fixed, and re-assigning the true owner :) |
||
►
Sign in to add a comment |
||
Comment 1 by l...@chromium.org
, Jul 25 2017