New issue
Advanced search Search tips

Issue 748726 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

Implement prediction in ash::HighlighterView

Project Member Reported by kaznacheev@chromium.org, Jul 25 2017

Issue description

Reuse FastInkPoints recently extracted from ash::LaserPointerView

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c1bc3b3e2fe8c5d773b23d6137c67f75402b922

commit 1c1bc3b3e2fe8c5d773b23d6137c67f75402b922
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Tue Aug 01 21:16:07 2017

Implement prediction in HighlighterView

Reuse FastInkPoints recently extracted from
ash::LaserPointerView.

Bug:  748726 
Change-Id: I5d8651f6179440a7438a62db48a7fa867f6a1ea4
Reviewed-on: https://chromium-review.googlesource.com/587613
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491112}
[modify] https://crrev.com/1c1bc3b3e2fe8c5d773b23d6137c67f75402b922/ash/BUILD.gn
[modify] https://crrev.com/1c1bc3b3e2fe8c5d773b23d6137c67f75402b922/ash/highlighter/highlighter_controller.cc
[modify] https://crrev.com/1c1bc3b3e2fe8c5d773b23d6137c67f75402b922/ash/highlighter/highlighter_controller.h
[add] https://crrev.com/1c1bc3b3e2fe8c5d773b23d6137c67f75402b922/ash/highlighter/highlighter_controller_test_api.cc
[add] https://crrev.com/1c1bc3b3e2fe8c5d773b23d6137c67f75402b922/ash/highlighter/highlighter_controller_test_api.h
[add] https://crrev.com/1c1bc3b3e2fe8c5d773b23d6137c67f75402b922/ash/highlighter/highlighter_controller_unittest.cc
[modify] https://crrev.com/1c1bc3b3e2fe8c5d773b23d6137c67f75402b922/ash/highlighter/highlighter_gesture_util.cc
[modify] https://crrev.com/1c1bc3b3e2fe8c5d773b23d6137c67f75402b922/ash/highlighter/highlighter_gesture_util.h
[modify] https://crrev.com/1c1bc3b3e2fe8c5d773b23d6137c67f75402b922/ash/highlighter/highlighter_gesture_util_unittest.cc
[modify] https://crrev.com/1c1bc3b3e2fe8c5d773b23d6137c67f75402b922/ash/highlighter/highlighter_view.cc
[modify] https://crrev.com/1c1bc3b3e2fe8c5d773b23d6137c67f75402b922/ash/highlighter/highlighter_view.h

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81abb02362441666f6df1cfd8bd98b657ae9b360

commit 81abb02362441666f6df1cfd8bd98b657ae9b360
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Thu Aug 03 01:02:18 2017

Implement prediction in HighlighterView

Reuse FastInkPoints recently extracted from
ash::LaserPointerView.

TBR=kaznacheev@google.com

(cherry picked from commit 1c1bc3b3e2fe8c5d773b23d6137c67f75402b922)

Bug:  748726 
Change-Id: I5d8651f6179440a7438a62db48a7fa867f6a1ea4
Reviewed-on: https://chromium-review.googlesource.com/587613
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491112}
Reviewed-on: https://chromium-review.googlesource.com/599449
Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#261}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/81abb02362441666f6df1cfd8bd98b657ae9b360/ash/BUILD.gn
[modify] https://crrev.com/81abb02362441666f6df1cfd8bd98b657ae9b360/ash/highlighter/highlighter_controller.cc
[modify] https://crrev.com/81abb02362441666f6df1cfd8bd98b657ae9b360/ash/highlighter/highlighter_controller.h
[add] https://crrev.com/81abb02362441666f6df1cfd8bd98b657ae9b360/ash/highlighter/highlighter_controller_test_api.cc
[add] https://crrev.com/81abb02362441666f6df1cfd8bd98b657ae9b360/ash/highlighter/highlighter_controller_test_api.h
[add] https://crrev.com/81abb02362441666f6df1cfd8bd98b657ae9b360/ash/highlighter/highlighter_controller_unittest.cc
[modify] https://crrev.com/81abb02362441666f6df1cfd8bd98b657ae9b360/ash/highlighter/highlighter_gesture_util.cc
[modify] https://crrev.com/81abb02362441666f6df1cfd8bd98b657ae9b360/ash/highlighter/highlighter_gesture_util.h
[modify] https://crrev.com/81abb02362441666f6df1cfd8bd98b657ae9b360/ash/highlighter/highlighter_gesture_util_unittest.cc
[modify] https://crrev.com/81abb02362441666f6df1cfd8bd98b657ae9b360/ash/highlighter/highlighter_view.cc
[modify] https://crrev.com/81abb02362441666f6df1cfd8bd98b657ae9b360/ash/highlighter/highlighter_view.h

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment