New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748720 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Bug in resource_scheduler_unittest where multiple field trials are being run in the same test

Project Member Reported by devdeepray@chromium.org, Jul 25 2017

Issue description

A single unit test cannot test more than one field trial configuration. Code for testing enabled and disabled field trial must be in separate tests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5374e93dded1c1e3cd96f617963682c88c308964

commit 5374e93dded1c1e3cd96f617963682c88c308964
Author: Devdeep Ray <devdeepray@chromium.org>
Date: Wed Jul 26 16:44:27 2017

Fix tests for varying maximum number of delayable requests

Bug:  748720 
Change-Id: I40050e341e1994e4df730282630adee7b907eb8e
Reviewed-on: https://chromium-review.googlesource.com/585375
Commit-Queue: Devdeep Ray <devdeepray@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489669}
[modify] https://crrev.com/5374e93dded1c1e3cd96f617963682c88c308964/content/browser/loader/resource_scheduler_unittest.cc

Labels: M-62
Status: Fixed (was: Started)

Sign in to add a comment