Detailed reasoning @ https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit#heading=h.rq9x8hbt9bq7 tl;dr; need to get rid of direct calls to MessageLoop if we want to support driving RunLoop from other abstractions (e.g. TestMockTimeTaskRunner). Since it's impossible to automate this migration, replace the bad call with a lesser bad call.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0592c3a469ac181a07925cf6488d9b4112e17006 commit 0592c3a469ac181a07925cf6488d9b4112e17006 Author: Gabriel Charette <gab@chromium.org> Date: Wed Jul 26 12:02:04 2017 Introduce RunLoop::QuitCurrent*Deprecated() to be favored over MessageLoop::Quit*() This is required to get rid of direct calls to MessageLoop in tests and allow for other abstractions to drive RunLoop (since it's impossible to migrate every test to RunLoop). Using message_loop_test.cc to test this. Those tests will go away when the deprecated methods can finally be removed but by then a lot of callers will be using the RunLoop versions and I don't think it will be possible to break them. R=danakj@chromium.org TBR=dpranke@chromium.org (PRESUBMIT.py) Bug: 748715 Change-Id: Ia0b996850a47bf24626a99c17b5985e8da826beb Reviewed-on: https://chromium-review.googlesource.com/585650 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#489611} [modify] https://crrev.com/0592c3a469ac181a07925cf6488d9b4112e17006/PRESUBMIT.py [modify] https://crrev.com/0592c3a469ac181a07925cf6488d9b4112e17006/base/message_loop/message_loop_test.cc [modify] https://crrev.com/0592c3a469ac181a07925cf6488d9b4112e17006/base/run_loop.cc [modify] https://crrev.com/0592c3a469ac181a07925cf6488d9b4112e17006/base/run_loop.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53a9ef81072f8390124df676dc9eda1856624e39 commit 53a9ef81072f8390124df676dc9eda1856624e39 Author: Gabriel Charette <gab@chromium.org> Date: Wed Jul 26 12:36:23 2017 Mass replace MessageLoop::Quit*() with RunLoop::QuitCurrent*Deprecated(). And added runloop.h alongside message_loop.h in allowed //base dependencies in Blink platform code as RunLoop is effectively an extension of MessageLoop and I don't see a reason not to allow it. TBR: danakj@chromium.org (for the scripted change) TBR: kinuko@chromium.org (for third_party\Webkit\Source\platform\DEPS tweak) Bug: 748715 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I36c934a0f22e3ee7ff44d3efb80c6a1fe710b7b5 Reviewed-on: https://chromium-review.googlesource.com/585732 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#489617} [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/ash/autoclick/mus/autoclick_application.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/ash/drag_drop/drag_drop_interactive_uitest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/ash/shelf/shelf_view_test_api.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/ash/shell/shell_delegate_impl.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/ash/touch_hud/mus/touch_hud_application.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/base/files/file_proxy_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/base/files/file_util_proxy_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/base/message_loop/message_loop.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/base/message_loop/message_loop_io_posix_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/base/message_loop/message_loop_task_runner_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/base/message_loop/message_loop_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/base/message_loop/message_pump_glib_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/base/synchronization/waitable_event_watcher_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/base/test/launcher/test_launcher.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/base/timer/timer_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/base/win/object_watcher_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/base/win/registry_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/cc/raster/raster_buffer_provider_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/cc/test/layer_tree_test.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/apps/app_window_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/autofill/autofill_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/autofill/autofill_uitest_util.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/browser_keyevents_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/browsing_data/browsing_data_media_license_helper_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/captive_portal/captive_portal_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/chromeos/customization/customization_wallpaper_downloader_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/chromeos/input_method/textinput_test_helper.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/chromeos/login/lock/screen_locker_tester.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/chromeos/login/ui/login_display_host_impl.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/devtools/device/usb/android_usb_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/devtools/devtools_file_system_indexer_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/devtools/devtools_sanity_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/download/download_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/activity_log/counting_policy_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/api/notifications/notifications_apitest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/api/tabs/tabs_test.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/api/top_sites/top_sites_apitest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/app_data_migrator_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/crx_installer_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/error_console/error_console_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/extension_action_icon_factory_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/extension_icon_manager_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/extension_service_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/extension_storage_monitor_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/extensions/permissions_updater_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/external_protocol/external_protocol_handler_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/geolocation/geolocation_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/history/android/sqlite_cursor_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/history/history_test_utils.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/importer/edge_importer_browsertest_win.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/importer/firefox_importer_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/importer/ie_importer_browsertest_win.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/importer/profile_writer_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/local_discovery/service_discovery_client_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/metrics/chromeos_metrics_provider_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/metrics/metrics_memory_details_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/net/dns_probe_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/net/sdch_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/password_manager/password_store_win_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/printing/cloud_print/privet_http_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/printing/cloud_print/privet_url_fetcher_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/printing/print_job.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/printing/print_view_manager_base.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/profiles/profile_list_desktop_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/profiles/profile_manager_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/profiles/profile_window_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/search_engines/template_url_fetcher_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/service_process/service_process_control_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/site_details_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/sync/profile_sync_test_util.h [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/sync/test/integration/bookmarks_helper.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/sync/test/integration/passwords_helper.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/sync/test/integration/status_change_checker.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/sync/test/integration/sync_test.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/cocoa/first_run_dialog.mm [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/input_method/input_method_engine_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/search/instant_extended_interactive_uitest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/test/test_browser_dialog.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/views/try_chrome_dialog_view.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/views/web_dialog_view_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/browser/ui/webui/web_ui_test_handler.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/test/base/in_process_browser_test.h [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/test/base/testing_profile.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/test/chromedriver/net/websocket_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chromecast/media/cma/backend/multizone_backend_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chromecast/media/cma/base/balanced_media_task_runner_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chromecast/media/cma/base/buffering_frame_provider_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chromecast/media/cma/base/demuxer_stream_adapter_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chromecast/media/cma/base/multi_demuxer_stream_adapter_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chromeos/dbus/services/service_provider_test_helper.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chromeos/login/auth/mock_auth_status_consumer.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/chromeos/login/auth/mock_url_fetchers.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/components/autofill/core/browser/webdata/web_data_service_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/components/browser_sync/profile_sync_service_typed_url_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/components/browser_sync/test_profile_sync_service.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/components/component_updater/component_updater_service_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/components/history/core/browser/history_service_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/components/omnibox/browser/autocomplete_provider_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/components/omnibox/browser/history_quick_provider_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/components/omnibox/browser/history_url_provider_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/components/spellcheck/browser/spellcheck_platform_mac_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/components/sync/driver/glue/sync_backend_host_impl_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/components/sync/engine_impl/sync_scheduler_impl_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/components/wifi/wifi_test.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/browser/browser_associated_interface_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/browser/browser_main_runner.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/browser/browser_thread_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/browser/device_sensors/device_sensor_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/browser/devtools/site_per_process_devtools_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/browser/download/download_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/browser/media/capture/web_contents_video_capture_device_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/browser/storage_partition_impl_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/browser/wake_lock/wake_lock_browsertest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/child/child_thread_impl.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/gpu/gpu_child_thread.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/public/test/download_test_observer.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/public/test/javascript_test_observer.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/public/test/test_service.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/public/test/test_utils.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/renderer/device_sensors/device_motion_event_pump_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/renderer/device_sensors/device_orientation_event_pump_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/renderer/gpu/render_widget_compositor_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/renderer/pepper/plugin_module.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/renderer/pepper/ppb_flash_message_loop_impl.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/content/test/appcache_test_helper.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/device/bluetooth/bluez/bluetooth_adapter_profile_bluez_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/device/bluetooth/bluez/bluetooth_bluez_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/device/bluetooth/test/test_bluetooth_adapter_observer.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/device/geolocation/geolocation_provider_impl_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/extensions/browser/api/alarms/alarms_api_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/extensions/browser/extension_icon_image_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/extensions/browser/file_reader_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/extensions/browser/image_loader_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/extensions/test/extension_test_message_listener.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/gin/modules/timer_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/gpu/ipc/service/gpu_channel_manager.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/ipc/ipc_channel_mojo_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/ipc/ipc_channel_proxy_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/ipc/ipc_fuzzing_tests.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/ipc/ipc_mojo_perftest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/ipc/ipc_send_fds_test.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/ipc/ipc_test_channel_listener.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/ipc/sync_socket_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/mash/catalog_viewer/catalog_viewer.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/mash/example/window_type_launcher/window_type_launcher.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/mash/quick_launch/quick_launch.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/mash/task_viewer/task_viewer.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/media/cast/test/sender.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/mojo/edk/js/threading.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/net/android/network_change_notifier_android_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/net/base/file_stream_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1856624e39/net/base/network_change_notifier_win_unittest.cc [modify] https://crrev.com/53a9ef81072f8390124df676dc9eda1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d93f55ed309c26701409034f3b00f8542a4b126 commit 2d93f55ed309c26701409034f3b00f8542a4b126 Author: Gabriel Charette <gab@chromium.org> Date: Wed Jul 26 14:38:11 2017 Manually migrate away from deprecated MessageLoop::Quit*() methods in /ui/app_list. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. TBR=khmel@chromium.org Bug: 748715 Change-Id: I55ed8de84916d19c8cf1586e609f95ce5a3ef436 Reviewed-on: https://chromium-review.googlesource.com/586848 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#489638} [modify] https://crrev.com/2d93f55ed309c26701409034f3b00f8542a4b126/ui/app_list/demo/app_list_demo_views.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74a1546a7c2ac0fe06b2925c329e61f7ba2803b3 commit 74a1546a7c2ac0fe06b2925c329e61f7ba2803b3 Author: Gabriel Charette <gab@chromium.org> Date: Wed Jul 26 15:16:53 2017 Manually migrate away from deprecated MessageLoop::Quit*() methods in /components/autofill. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. R=estade@chromium.org Bug: 748715 Change-Id: I04c659920c9de34ffed2f985314a4f7603737c7a Reviewed-on: https://chromium-review.googlesource.com/586854 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#489648} [modify] https://crrev.com/74a1546a7c2ac0fe06b2925c329e61f7ba2803b3/components/autofill/content/browser/risk/fingerprint_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe80709efc0c017e1fada9e7040ef47f221b7fa4 commit fe80709efc0c017e1fada9e7040ef47f221b7fa4 Author: Gabriel Charette <gab@chromium.org> Date: Wed Jul 26 17:57:03 2017 Manually migrate away from deprecated MessageLoop::Quit*() methods in /media. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. R=liberato@chromium.org Bug: 748715 Change-Id: I995174fb611b7a1f4cd6d4a7b3c0f5cfde8bd1c0 Reviewed-on: https://chromium-review.googlesource.com/586851 Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#489689} [modify] https://crrev.com/fe80709efc0c017e1fada9e7040ef47f221b7fa4/media/base/serial_runner_unittest.cc [modify] https://crrev.com/fe80709efc0c017e1fada9e7040ef47f221b7fa4/media/test/pipeline_integration_test_base.cc [modify] https://crrev.com/fe80709efc0c017e1fada9e7040ef47f221b7fa4/media/test/pipeline_integration_test_base.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbcf7b8f70a0eb6cff1b849b36a8b7dec248888a commit dbcf7b8f70a0eb6cff1b849b36a8b7dec248888a Author: Gabriel Charette <gab@chromium.org> Date: Wed Jul 26 18:29:20 2017 Manually migrate away from deprecated MessageLoop::Quit*() methods in /remoting. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. R=lambroslambrou@chromium.org Bug: 748715 Change-Id: I3deffeeb08a5b2d780a3cfcfb121cf31b6752d81 Reviewed-on: https://chromium-review.googlesource.com/586849 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#489704} [modify] https://crrev.com/dbcf7b8f70a0eb6cff1b849b36a8b7dec248888a/remoting/host/setup/start_host_main.cc [modify] https://crrev.com/dbcf7b8f70a0eb6cff1b849b36a8b7dec248888a/remoting/host/token_validator_factory_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f788b31594ace19c727dd433031408e860f1db4 commit 1f788b31594ace19c727dd433031408e860f1db4 Author: Gabriel Charette <gab@chromium.org> Date: Wed Jul 26 19:25:15 2017 Manually migrate away from more deprecated MessageLoop::Quit*() methods in /chrome/browser/printing. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. R=scottbyer@chromium.org Bug: 748715 Change-Id: I89ee25215331f116bfdfe047c73e49dda00c1518 Reviewed-on: https://chromium-review.googlesource.com/587050 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Scott Byer <scottbyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#489722} [modify] https://crrev.com/1f788b31594ace19c727dd433031408e860f1db4/chrome/browser/printing/print_view_manager_base.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6bd4d614c4572c88b06199979b4bb926f3f8aec commit b6bd4d614c4572c88b06199979b4bb926f3f8aec Author: Gabriel Charette <gab@chromium.org> Date: Wed Jul 26 20:26:12 2017 Manually migrate away from deprecated MessageLoop::Quit*() methods in /base. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. TBR=danakj@chromium.org Bug: 748715 Change-Id: I05cb58337fa9824f21b3df127a3b126d40bac8f0 Reviewed-on: https://chromium-review.googlesource.com/586855 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#489740} [modify] https://crrev.com/b6bd4d614c4572c88b06199979b4bb926f3f8aec/base/message_loop/message_loop.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9fecd3ea862a28eb727c3ef5e386a57b21d60b9 commit a9fecd3ea862a28eb727c3ef5e386a57b21d60b9 Author: Gabriel Charette <gab@chromium.org> Date: Wed Jul 26 22:53:56 2017 Manually migrate away from more deprecated MessageLoop::Quit*() methods in /net. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. R=mattm@chromium.org Bug: 748715 Change-Id: Id5555f9c375858a475ec0b0b3eebaa094b70b5be Reviewed-on: https://chromium-review.googlesource.com/587051 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#489786} [modify] https://crrev.com/a9fecd3ea862a28eb727c3ef5e386a57b21d60b9/net/base/network_change_notifier_win_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/306cb1283080693050a1018736219b7642b12803 commit 306cb1283080693050a1018736219b7642b12803 Author: Gabriel Charette <gab@chromium.org> Date: Wed Jul 26 23:33:25 2017 Manually migrate away from deprecated MessageLoop::Quit*() methods in /chrome/browser/chromeos/login. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. R=jdufault@chromium.org Bug: 748715 Change-Id: Icd9fd3daacf606385cf08015ed25feea8acdce14 Reviewed-on: https://chromium-review.googlesource.com/586852 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#489797} [modify] https://crrev.com/306cb1283080693050a1018736219b7642b12803/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/349c1b08799f259692374b0da5880d11abc3da5e commit 349c1b08799f259692374b0da5880d11abc3da5e Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 16:32:31 2017 Manually migrate away from deprecated MessageLoop::Quit*() methods in /components/wallpaper. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. R=bshe@chromium.org Bug: 748715 Change-Id: I287b4b35961d24974524fb489cc0a56d1ffbeeb7 Reviewed-on: https://chromium-review.googlesource.com/586853 Reviewed-by: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#489966} [modify] https://crrev.com/349c1b08799f259692374b0da5880d11abc3da5e/components/wallpaper/wallpaper_resizer_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3769cfc3b89f469aa35f03e52f7815237f7b261 commit e3769cfc3b89f469aa35f03e52f7815237f7b261 Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 16:52:50 2017 Remove redundant MessageLoop::QuitWhenIdle() calls from ExtensionServiceTest The callers already content::RunAllBlockingPoolTasksUntilIdle() which internally uses RunLoop::RunUntilIdle() so the "quit when idle" bit is already set. R=rockot@chromium.org Bug: 748715 Change-Id: Ibbf58c77a54ab17cd82427f796bd866058efd9b1 Reviewed-on: https://chromium-review.googlesource.com/587344 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#489980} [modify] https://crrev.com/e3769cfc3b89f469aa35f03e52f7815237f7b261/chrome/browser/extensions/extension_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8189f2671914bd2f1440db0bcbfb1bdce58bfda commit a8189f2671914bd2f1440db0bcbfb1bdce58bfda Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 16:56:13 2017 Manually migrate away from more deprecated MessageLoop::Quit*() methods in /chrome/browser/policy. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. TBR=pastarmovj@chromium.org Bug: 748715 Change-Id: I7bb014735ead248b24a06c0cac99ebf53ecb763a Reviewed-on: https://chromium-review.googlesource.com/587010 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#489981} [modify] https://crrev.com/a8189f2671914bd2f1440db0bcbfb1bdce58bfda/chrome/browser/policy/cloud/device_management_service_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35dfc26e9cce1d89bf3a7941691f68e9041507c4 commit 35dfc26e9cce1d89bf3a7941691f68e9041507c4 Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 16:56:47 2017 Manually migrate away from more deprecated MessageLoop::Quit*() methods in /remoting. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. TBR=kelvinp@chromium.org Bug: 748715 Change-Id: I1b382975a0a5aaa5636445fd0b75613173a46efa Reviewed-on: https://chromium-review.googlesource.com/587148 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#489982} [modify] https://crrev.com/35dfc26e9cce1d89bf3a7941691f68e9041507c4/remoting/protocol/monitored_video_stub_unittest.cc [modify] https://crrev.com/35dfc26e9cce1d89bf3a7941691f68e9041507c4/remoting/signaling/iq_sender_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b8dcf87d02c842dc1657f910eca1831ecaf3cba commit 3b8dcf87d02c842dc1657f910eca1831ecaf3cba Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 16:57:52 2017 Manually migrate away from more deprecated MessageLoop::Quit*() methods in /content/browser/loader. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. TBR=rdsmith@chromium.org Bug: 748715 Change-Id: Id3ccdf1609c6a05e6a9200a863033fcf29813a55 Reviewed-on: https://chromium-review.googlesource.com/587089 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#489983} [modify] https://crrev.com/3b8dcf87d02c842dc1657f910eca1831ecaf3cba/content/browser/loader/resource_dispatcher_host_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f138c08eae304d9c42026e42aa246f21e89002d commit 9f138c08eae304d9c42026e42aa246f21e89002d Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 17:14:26 2017 Manually migrate away from deprecated MessageLoop::Quit*() methods in /device/geolocation. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. TBR=timvolodine@chromium.org Bug: 748715 Change-Id: I1a28c8112da05f333f79fafeb34a75b2ae0b5b74 Reviewed-on: https://chromium-review.googlesource.com/586907 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#489999} [modify] https://crrev.com/9f138c08eae304d9c42026e42aa246f21e89002d/device/geolocation/network_location_provider_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0304a814fb97c32f549537cd595c2edfd688e6e1 commit 0304a814fb97c32f549537cd595c2edfd688e6e1 Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 17:39:44 2017 Manually migrate away from deprecated MessageLoop::Quit*() methods in /chrome. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 748715 Change-Id: I2ea049402f60a7719f4b3b7093b5cb3f4f8ede03 Reviewed-on: https://chromium-review.googlesource.com/586887 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#490014} [modify] https://crrev.com/0304a814fb97c32f549537cd595c2edfd688e6e1/chrome/profiling/profiling_globals.cc [modify] https://crrev.com/0304a814fb97c32f549537cd595c2edfd688e6e1/chrome/profiling/profiling_globals.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82af4bcf2b162206a52ff67e21916a5d9e6159f5 commit 82af4bcf2b162206a52ff67e21916a5d9e6159f5 Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 23:05:10 2017 Manually migrate away from deprecated MessageLoop::Quit*() methods in /components/sync. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. R=skym@chromium.org Bug: 748715 Change-Id: Icaacef229c81ea8290253a16d4b592adbc8cec6f Reviewed-on: https://chromium-review.googlesource.com/586911 Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#490061} [modify] https://crrev.com/82af4bcf2b162206a52ff67e21916a5d9e6159f5/components/sync/base/get_session_name_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b2bef1d7d7b5c0cc15c30caff2da9f5dcd3bf66 commit 1b2bef1d7d7b5c0cc15c30caff2da9f5dcd3bf66 Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 23:06:50 2017 Manually migrate away from last few deprecated MessageLoop::Quit*() methods in safe_browsing. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). R=nparker@chromium.org Bug: 748715 Change-Id: If578c5b29b8d611dbc844b57e90a3794bddbb4e9 Reviewed-on: https://chromium-review.googlesource.com/590073 Commit-Queue: Nathan Parker <nparker@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#490064} [modify] https://crrev.com/1b2bef1d7d7b5c0cc15c30caff2da9f5dcd3bf66/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc [modify] https://crrev.com/1b2bef1d7d7b5c0cc15c30caff2da9f5dcd3bf66/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc5739e84fcc21a4ec3ab433ab6190c9b7f12154 commit bc5739e84fcc21a4ec3ab433ab6190c9b7f12154 Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 23:09:31 2017 Manually migrate away from deprecated MessageLoop::Quit*() methods in /content/renderer. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. R=dglazkov@chromium.org Bug: 748715 Change-Id: I6191937397a05bdd7daaac21ec46a6a77ae773c2 Reviewed-on: https://chromium-review.googlesource.com/586908 Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#490068} [modify] https://crrev.com/bc5739e84fcc21a4ec3ab433ab6190c9b7f12154/content/renderer/render_thread_impl_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c65ee756da28e921c0b737f2c1bd408d72fe5d3 commit 6c65ee756da28e921c0b737f2c1bd408d72fe5d3 Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 23:14:39 2017 Manually migrate away from deprecated MessageLoop::Quit*() methods in /chrome/service. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. R=vitalybuka@chromium.org Bug: 748715 Change-Id: I38b9e5ab4d691074b21a00b6bbb76cd382a44a0f Reviewed-on: https://chromium-review.googlesource.com/586910 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#490077} [modify] https://crrev.com/6c65ee756da28e921c0b737f2c1bd408d72fe5d3/chrome/service/cloud_print/printer_job_handler_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/616ad8055fd18af6d0817618884d893492c44a8d commit 616ad8055fd18af6d0817618884d893492c44a8d Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 23:21:13 2017 Manually migrate away from last few deprecated MessageLoop::Quit*() methods in /content/browser/loader. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. TBR=yhirano@chromium.org Bug: 748715 Change-Id: Ife0c638ad3fe50fa41cc0c0f54a014e8e1c69ac4 Reviewed-on: https://chromium-review.googlesource.com/590090 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#490087} [modify] https://crrev.com/616ad8055fd18af6d0817618884d893492c44a8d/content/browser/loader/resource_dispatcher_host_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e855df32767d67cac8f0edab714e3770b8dbf74d commit e855df32767d67cac8f0edab714e3770b8dbf74d Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 23:24:23 2017 Manually migrate away from last few deprecated MessageLoop::Quit*() methods in /components/history. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. TBR=sky@chromium.org Bug: 748715 Change-Id: I9737530ebd5289d7c6ec11b595a0c1c16270ad92 Reviewed-on: https://chromium-review.googlesource.com/590089 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#490092} [modify] https://crrev.com/e855df32767d67cac8f0edab714e3770b8dbf74d/components/history/core/browser/history_querying_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a128a7989f6f93b7f6590a310ae9efa29a281e7 commit 9a128a7989f6f93b7f6590a310ae9efa29a281e7 Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 23:43:36 2017 Manually migrate away from last few deprecated MessageLoop::Quit*() methods in /media. This follows an automated pass for simpler use cases @ https://chromium-review.googlesource.com/c/585732/. Minimal cleanup was made when trivial. (some calls were even removed as they merely added a redundant QuitWhenIdle() to a RunLoop().RunUntilIdle() call) When too complex I defaulted to the lesser bad alternative of RunLoop::QuitCurrent*Deprecated() methods. I will not engage in further cleanups as part of this massive change -- owners are welcome to follow suit with better usage of RunLoop if unsatisfied with this). This CL was uploaded by git cl split. TBR=liberato@chromium.org Bug: 748715 Change-Id: I5fca0ffcc98ffb8ed4ce6e693a5efb564d3cd113 Reviewed-on: https://chromium-review.googlesource.com/590068 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#490123} [modify] https://crrev.com/9a128a7989f6f93b7f6590a310ae9efa29a281e7/media/test/pipeline_integration_test_base.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adadcc78dcdc4deb909c9872078392497f1d7064 commit adadcc78dcdc4deb909c9872078392497f1d7064 Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 27 23:51:33 2017 Migrate away from deprecated MessageLoop::QuitWhenIdle() in java_handler_thread.cc This is one of the very last calls in the codebase. base::RunLoop::QuitCurrentWhenIdleDeprecated() is equivalent to what base::MessageLoop::QuitWhenIdle() used to do. Bug: 748715 Change-Id: I2ca9626d771e62b3ba8cbf6164d93ae13a4e05ef Reviewed-on: https://chromium-review.googlesource.com/590100 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#490136} [modify] https://crrev.com/adadcc78dcdc4deb909c9872078392497f1d7064/base/android/java_handler_thread.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/babad53a609fc2873fd6997156fd02a754917877 commit babad53a609fc2873fd6997156fd02a754917877 Author: Gabriel Charette <gab@chromium.org> Date: Sat Jul 29 00:43:27 2017 Migrate away from very last call to deprecated MessageLoop::QuitNow() R=nyquist@chromium.org Bug: 748715 Change-Id: I89c6c8c9f4a94202f26dbe9201b78ecbf07b2a7f Reviewed-on: https://chromium-review.googlesource.com/592271 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#490560} [modify] https://crrev.com/babad53a609fc2873fd6997156fd02a754917877/base/test/android/java_handler_thread_for_testing.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f87673db2ebe0e8dd9d191c7aed4cc85480c587 commit 8f87673db2ebe0e8dd9d191c7aed4cc85480c587 Author: Gabriel Charette <gab@chromium.org> Date: Sat Jul 29 00:56:02 2017 Migrate away from last call to MessageLoop::QuitWhenIdle() in entire codebase. base::RunLoop::QuitCurrentWhenIdleDeprecated() results in the exact same behaviour but avoids a dependency on MessageLoop. R=rockot@chromium.org Bug: 748715 Change-Id: I66d4acb70f9cbc4a7360f88ad7d68edc17ea83a0 Reviewed-on: https://chromium-review.googlesource.com/591879 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#490563} [modify] https://crrev.com/8f87673db2ebe0e8dd9d191c7aed4cc85480c587/mojo/android/system/base_run_loop.cc [modify] https://crrev.com/8f87673db2ebe0e8dd9d191c7aed4cc85480c587/mojo/android/system/src/org/chromium/mojo/system/impl/BaseRunLoop.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9839bcaf4d62f439662b5e93f8be3c10dad4e99 commit d9839bcaf4d62f439662b5e93f8be3c10dad4e99 Author: Gabriel Charette <gab@chromium.org> Date: Sat Jul 29 14:17:47 2017 Remove MessageLoop::Quit(Now|WhenIdle) for good! Leaving static MessageLoop::QuitWhenIdleClosure() behind as a mere redirect but flagging it in presubmits so its usage dwindles overtime. R=danakj@chromium.org Bug: 748715 Change-Id: I523c6e598f0de5c9d326ae2764cd6e2502be9cc4 Reviewed-on: https://chromium-review.googlesource.com/586889 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#490655} [modify] https://crrev.com/d9839bcaf4d62f439662b5e93f8be3c10dad4e99/PRESUBMIT.py [modify] https://crrev.com/d9839bcaf4d62f439662b5e93f8be3c10dad4e99/base/message_loop/message_loop.cc [modify] https://crrev.com/d9839bcaf4d62f439662b5e93f8be3c10dad4e99/base/message_loop/message_loop.h [modify] https://crrev.com/d9839bcaf4d62f439662b5e93f8be3c10dad4e99/base/run_loop.h
WoohoooOOOoOOoO!!!!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d7bc54757bc828e06a454c68b4dd9a3ec8f23d9 commit 5d7bc54757bc828e06a454c68b4dd9a3ec8f23d9 Author: Vasiliy Tsukanov <palar@yandex-team.ru> Date: Sun Nov 12 01:35:09 2017 Fixed TestBrowserDialog use of base::RunLoop::QuitCurrentDeprecated(). Bug: 748715 Change-Id: I3aed198d5a6ddb0b776f60c2358701953630078c Reviewed-on: https://chromium-review.googlesource.com/725333 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#515858} [modify] https://crrev.com/5d7bc54757bc828e06a454c68b4dd9a3ec8f23d9/chrome/browser/ui/test/test_browser_dialog.cc [add] https://crrev.com/5d7bc54757bc828e06a454c68b4dd9a3ec8f23d9/chrome/browser/ui/test/test_browser_dialog_mac.h [rename] https://crrev.com/5d7bc54757bc828e06a454c68b4dd9a3ec8f23d9/chrome/browser/ui/test/test_browser_dialog_mac.mm [modify] https://crrev.com/5d7bc54757bc828e06a454c68b4dd9a3ec8f23d9/chrome/test/BUILD.gn [modify] https://crrev.com/5d7bc54757bc828e06a454c68b4dd9a3ec8f23d9/ui/base/BUILD.gn [delete] https://crrev.com/7279e07b35ea0176c8dd4d10fec70b28e285bd7b/ui/base/test/user_interactive_test_case.cc [delete] https://crrev.com/7279e07b35ea0176c8dd4d10fec70b28e285bd7b/ui/base/test/user_interactive_test_case.h
Comment 1 by bugdroid1@chromium.org
, Jul 26 2017