New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748704 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Disable gesture dragging of shelf if fullscreen launcher is opened.

Project Member Reported by minch@chromium.org, Jul 25 2017

Issue description

Make the shelf can't be dragged if the fullscreen launcher is opened.
This includes swiping up and down on the shelf.
 

Comment 1 by minch@chromium.org, Jul 26 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/768d1677165e9bfb2c4af859b2dafb0293d7d81e

commit 768d1677165e9bfb2c4af859b2dafb0293d7d81e
Author: MinChen <minch@chromium.org>
Date: Thu Jul 27 16:42:59 2017

Disable shelf dragging if fullscreen app list is opened.

Bug:  748704 
Change-Id: Ib3eb5410c1b838a412595a4561523f7e181a35df
Reviewed-on: https://chromium-review.googlesource.com/587410
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489973}
[modify] https://crrev.com/768d1677165e9bfb2c4af859b2dafb0293d7d81e/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/768d1677165e9bfb2c4af859b2dafb0293d7d81e/ash/shelf/shelf_layout_manager_unittest.cc

Comment 3 by minch@chromium.org, Jul 27 2017

Labels: Merge-Request-61
launcher cl for 61.

Comment 4 by gov...@chromium.org, Jul 27 2017

Pls apply appropriate OSs.

Comment 5 by minch@chromium.org, Jul 27 2017

Labels: OS-Chrome
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 31 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 31 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c9c314ee55c1302fa5689e6f38311f1b5f14683

commit 3c9c314ee55c1302fa5689e6f38311f1b5f14683
Author: Maajid <maajid@chromium.org>
Date: Mon Jul 31 22:06:24 2017

Disable shelf dragging if fullscreen app list is opened.

TBR=minch@chromium.org

(cherry picked from commit 768d1677165e9bfb2c4af859b2dafb0293d7d81e)

Bug:  748704 
Change-Id: Ib3eb5410c1b838a412595a4561523f7e181a35df
Reviewed-on: https://chromium-review.googlesource.com/587410
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489973}
Reviewed-on: https://chromium-review.googlesource.com/594683
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#190}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/3c9c314ee55c1302fa5689e6f38311f1b5f14683/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/3c9c314ee55c1302fa5689e6f38311f1b5f14683/ash/shelf/shelf_layout_manager_unittest.cc

Comment 9 by minch@chromium.org, Aug 1 2017

Status: Fixed (was: Started)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment