New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748700 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

vmlog output is hard to use

Project Member Reported by teravest@chromium.org, Jul 25 2017

Issue description

While tracking down performance issues reported here:
https://listnr.corp.google.com/report/69149412199

I was trying to correlate statistics reported by vmlog with events reported by chrome to see how closely we can match up swap activity with jank.

However, they use two different clocks (vmlog uses time-since-boot, like dmesg). This requires some extra manual work.

Additionally, using counters makes it hard to scan for large events; given how much history we're able to collect, maybe we should just provide deltas instead?
 

Comment 1 by sonny...@google.com, Jul 25 2017

+1 to showing deltas and showing system time
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3c1ed94d1dd204fbd12c15bdf20458abab28f19c

commit 3c1ed94d1dd204fbd12c15bdf20458abab28f19c
Author: Justin TerAvest <teravest@chromium.org>
Date: Thu Aug 17 06:37:55 2017

metrics: Improve vmlog output lines.

Currently, vmlog files are hard to interpret and require messing around
with shell scripting to get deltas between values, and rough matching
with syslog to match up dmesg timestamps with the rest of the logs in
the system.

This change:
  (1) Reports deltas instead of absolute vmstat values, and
  (2) Updates the time formatting to closely match that of chrome logs.

BUG= chromium:748700 
TEST=Manually built and deployed "metrics", examined logfile.

Change-Id: I6ba0c584965e8cd79fecfc70656bda5f5c3e00f3
Reviewed-on: https://chromium-review.googlesource.com/615019
Commit-Ready: Justin TerAvest <teravest@chromium.org>
Tested-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org>

[modify] https://crrev.com/3c1ed94d1dd204fbd12c15bdf20458abab28f19c/metrics/vmlog_writer.cc
[modify] https://crrev.com/3c1ed94d1dd204fbd12c15bdf20458abab28f19c/metrics/vmlog_writer.h

Status: Fixed (was: Untriaged)

Sign in to add a comment