MusContextFactory should not hold a RendererSettings |
|||
Issue descriptionRendererSettings is a privileged class. MusContextFactory should not own one since MCF is only a client but not a host. MCF only uses the BufferToTextureTargetMap (which it creates itself) anyway.
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4ef1c993f66d2aad1d5b20039ade00fdd9a5f6e commit c4ef1c993f66d2aad1d5b20039ade00fdd9a5f6e Author: Alex Zhang <staraz@chromium.org> Date: Thu Jul 27 23:31:19 2017 Replace MusContextFactory::renderer_settings_ with a ResourceSettings viz::RendererSettings is a privileged class. MusContextFactory should not own one because it is a client not a host. Replace |renderer_settings_| with |resource_settings_| for it is all a ContextFactory needs. Bug: 748699 Change-Id: Ib1e453650ac77aeb796b57e76e06d18a20226401 Reviewed-on: https://chromium-review.googlesource.com/589547 Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xingyu Zhang <staraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#490103} [modify] https://crrev.com/c4ef1c993f66d2aad1d5b20039ade00fdd9a5f6e/ui/aura/mus/mus_context_factory.cc [modify] https://crrev.com/c4ef1c993f66d2aad1d5b20039ade00fdd9a5f6e/ui/aura/mus/mus_context_factory.h [modify] https://crrev.com/c4ef1c993f66d2aad1d5b20039ade00fdd9a5f6e/ui/compositor/compositor_util.cc [modify] https://crrev.com/c4ef1c993f66d2aad1d5b20039ade00fdd9a5f6e/ui/compositor/compositor_util.h
,
Jul 28 2017
,
Feb 26 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by staraz@chromium.org
, Jul 25 2017