New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748698 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 713830



Sign in to add a comment

Update Welcome Apps texts

Project Member Reported by wzang@chromium.org, Jul 25 2017

Issue description

Comment 1 by wzang@chromium.org, Jul 25 2017

Blocking: 713830
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09ba31f0f3ac6ee9a665788abd4b370dfa6b121f

commit 09ba31f0f3ac6ee9a665788abd4b370dfa6b121f
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Jul 25 23:21:17 2017

Update Welcome App texts

Following the spec here:
https://docs.google.com/presentation/d/1iqxdoxEi_EpmUOUpL6mTxeToo-i9CV1S2yvdS04Cxu8/edit#slide=id.g1e8de3e9ef_0_13

Bug:  748698 
Change-Id: Ifa8375d638b10d9b92364020ab7cfbca2f787ca9
Reviewed-on: https://chromium-review.googlesource.com/584859
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489479}
[modify] https://crrev.com/09ba31f0f3ac6ee9a665788abd4b370dfa6b121f/chrome/app/chromeos_strings.grdp

Comment 3 by wzang@chromium.org, Jul 26 2017

Cc: weifangsun@chromium.org
Weifang, in Welcome-3, do we want to remove the line 'want to discover more awesome features?'  https://docs.google.com/presentation/d/1g-ocUpzvlKvtLIV6kz3WUqRThkfF3WMlZFLKsouinAA/edit?ts=5967ea20#slide=id.g1e8de3e9ef_0_13

Thanks!
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcc7e00950ae4212bee0ba4967466683d38d1cbf

commit fcc7e00950ae4212bee0ba4967466683d38d1cbf
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Wed Jul 26 10:46:15 2017

Revert "Update Welcome App texts"

This reverts commit 09ba31f0f3ac6ee9a665788abd4b370dfa6b121f.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Update Welcome App texts
> 
> Following the spec here:
> https://docs.google.com/presentation/d/1iqxdoxEi_EpmUOUpL6mTxeToo-i9CV1S2yvdS04Cxu8/edit#slide=id.g1e8de3e9ef_0_13
> 
> Bug:  748698 
> Change-Id: Ifa8375d638b10d9b92364020ab7cfbca2f787ca9
> Reviewed-on: https://chromium-review.googlesource.com/584859
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#489479}

TBR=jcivelli@chromium.org,wzang@chromium.org

Change-Id: I3776df5e6556e46a008a75ff2902efbe1a46be0d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  748698 
Reviewed-on: https://chromium-review.googlesource.com/586487
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489599}
[modify] https://crrev.com/fcc7e00950ae4212bee0ba4967466683d38d1cbf/chrome/app/chromeos_strings.grdp

wzang@ - Yes, for welcome-3, we should remove the last line in the current dialog.


Also, just to confirm, the final copy is in go/cros-ha-welcome - Looks like you might have linked the copy/edit deck as well/
Components: Platform>Apps>GetHelp
Labels: OS-Chrome
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2651d426c8c8fd0b85d9c7a8a85883b0579daf5d

commit 2651d426c8c8fd0b85d9c7a8a85883b0579daf5d
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Jul 27 08:46:32 2017

Update Welcome App texts and remove $1 placeholder

A reland of 584859 after updating first_run_ui.cc

Bug:  748698 ,  749024 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic62094e0965d534c8b528e5801182d7febe7ad7d
Reviewed-on: https://chromium-review.googlesource.com/587289
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489885}
[modify] https://crrev.com/2651d426c8c8fd0b85d9c7a8a85883b0579daf5d/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/2651d426c8c8fd0b85d9c7a8a85883b0579daf5d/chrome/browser/resources/chromeos/first_run/help_step.html
[modify] https://crrev.com/2651d426c8c8fd0b85d9c7a8a85883b0579daf5d/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc

Comment 8 by wzang@chromium.org, Jul 27 2017

Cc: r...@chromium.org
Status: Fixed (was: Assigned)

Comment 9 by wzang@chromium.org, Jul 27 2017

Labels: Merge-Request-61
This contains string updates. Needs approval by this Friday. Thanks.
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 28 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 38 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by wzang@chromium.org, Jul 28 2017

Cc: keta...@chromium.org
ketakid@, can we get this approved by 5pm today for translation? Thanks.
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 28 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c86ad30d94d466286595bfa2257ddcb82f93f873

commit c86ad30d94d466286595bfa2257ddcb82f93f873
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Jul 28 22:40:49 2017

Update Welcome App texts and remove $1 placeholder

A reland of 584859 after updating first_run_ui.cc

TBR=wzang@chromium.org

(cherry picked from commit 2651d426c8c8fd0b85d9c7a8a85883b0579daf5d)

Bug:  748698 ,  749024 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic62094e0965d534c8b528e5801182d7febe7ad7d
Reviewed-on: https://chromium-review.googlesource.com/587289
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489885}
Reviewed-on: https://chromium-review.googlesource.com/592423
Cr-Commit-Position: refs/branch-heads/3163@{#119}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/c86ad30d94d466286595bfa2257ddcb82f93f873/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/c86ad30d94d466286595bfa2257ddcb82f93f873/chrome/browser/resources/chromeos/first_run/help_step.html
[modify] https://crrev.com/c86ad30d94d466286595bfa2257ddcb82f93f873/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc

Comment 14 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment