New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 748684 link

Starred by 1 user
Status: Archived
Owner:
█ pho...@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

apache_*_metrics scripts create too many logs

Project Member Reported by pho...@chromium.org, Jul 25 2017 
This morning when looking into why chromeos-server100.mtv had crashed, I noticed the log file for apache_access_log_metrics.py was 3.6G, and full of messages about the metrics it was emitting. This is pretty useless since we can just go and visit the metrics directly - logging them to a file isn't helpful.

It's more useful to just log start/stops and crashes.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f47d0d20e811bf8c6e3b31d71cd22071131dea26

commit f47d0d20e811bf8c6e3b31d71cd22071131dea26
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Aug 03 08:11:06 2017

stats/log_daemon_common: Don't log to stdout

Logging to stdout causes the log files for scripts such as
apache_access_log_metrics to become huge (many gigabytes) very quickly. Logging
individual metrics is not very useful for a debugging standpoint, because you
can just look at the actual metrics anyway. When running locally, using
--debug-metrics-file will print out the metrics it creates to stdout and send
them to a file.

Remove the debug log message which is emitted every time a line is matched.

BUG= chromium:748684 
TEST=unit tests still pass.

Change-Id: I50469108b9df27636e05dd402f545032f8bebcb3
Reviewed-on: https://chromium-review.googlesource.com/585614
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>

[modify] https://crrev.com/f47d0d20e811bf8c6e3b31d71cd22071131dea26/site_utils/stats/log_daemon_common.py

Comment 2 by pho...@chromium.org, Aug 23 2017

Status: Fixed (was: Started)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment