New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748680 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
please use my google.com address
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

20 kb regression in resource_sizes (MonochromePublic.apk) at 489326:489326

Project Member Reported by estevenson@chromium.org, Jul 25 2017

Issue description

Caused by “Reland Mojo C++ Bindings: Dynamic message allocation”

Commit: 9ea314373dcd35d1a7a2dc48627d18831d6e789f

Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=489326

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on the graph: all native code growth.

It's not clear to me whether or not this increase was expected. Please have a look and either:
1) Close as “Won't Fix” with a short justification, or
2) Land a revert / fix-up.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jul 25 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=748680

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1cd6a6ea6e2bd0d4a61c5f845bb0307c8ff1846570425dea90ae5ddc414aa2da


Bot(s) for this bug's original alert(s):

Android Builder
Labels: OS-Android
Owner: roc...@chromium.org
Status: Assigned (was: Untriaged)
diff_results.txt
1.6 MB View Download

Comment 3 by roc...@chromium.org, Jul 25 2017

Status: WontFix (was: Assigned)
This increase is expected but allows us to delete other code in follow-up changes. Discussion here: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/ruS9e8CMiws

Sign in to add a comment