New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748669 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Playstore search results blink on and off when a text is entered in the searchbox

Project Member Reported by vadimt@chromium.org, Jul 25 2017

Issue description

#bugbashcros61
 

Comment 1 by vadimt@chromium.org, Jul 25 2017

Another report:
Play store search results flickr on every keypress. Past results should wait for new results before clearing the old content
P0 at bug bash.
Cc: hejq@chromium.org
Labels: -Pri-3 Pri-1
Owner: vadimt@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/049b8b72186ea114ee32b81449d0eb1a4f947759

commit 049b8b72186ea114ee32b81449d0eb1a4f947759
Author: Vadim Tryshev <vadimt@google.com>
Date: Mon Aug 07 19:37:17 2017

Reduce Playstore search result flickering.

There is still flicker but less annoying. Further improvements are
possible, and they will be built on top of this change.

Now the provider deals with results same was as AppSearchProvider.

Also removing some dead code.

Bug:  748669 
Change-Id: I8267f9076e06774a3997a5b48f7e7ed616248152
Reviewed-on: https://chromium-review.googlesource.com/602380
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492382}
[modify] https://crrev.com/049b8b72186ea114ee32b81449d0eb1a4f947759/ash/shell/app_list.cc
[modify] https://crrev.com/049b8b72186ea114ee32b81449d0eb1a4f947759/chrome/browser/ui/app_list/app_list_view_delegate.cc
[modify] https://crrev.com/049b8b72186ea114ee32b81449d0eb1a4f947759/chrome/browser/ui/app_list/app_list_view_delegate.h
[modify] https://crrev.com/049b8b72186ea114ee32b81449d0eb1a4f947759/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider.cc
[modify] https://crrev.com/049b8b72186ea114ee32b81449d0eb1a4f947759/ui/app_list/app_list_view_delegate.h
[modify] https://crrev.com/049b8b72186ea114ee32b81449d0eb1a4f947759/ui/app_list/test/app_list_test_view_delegate.h

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80e1e3fadfd064342462b28f053b89100d558fe5

commit 80e1e3fadfd064342462b28f053b89100d558fe5
Author: Vadim Tryshev <vadimt@google.com>
Date: Tue Aug 08 01:09:42 2017

Reduce Playstore search result flickering.

There is still flicker but less annoying. Further improvements are
possible, and they will be built on top of this change.

Now the provider deals with results same was as AppSearchProvider.

Also removing some dead code.

TBR=vadimt@google.com

(cherry picked from commit 049b8b72186ea114ee32b81449d0eb1a4f947759)

Bug:  748669 
Change-Id: I8267f9076e06774a3997a5b48f7e7ed616248152
Reviewed-on: https://chromium-review.googlesource.com/602380
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Vadim Tryshev <vadimt@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492382}
Reviewed-on: https://chromium-review.googlesource.com/604987
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#374}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/80e1e3fadfd064342462b28f053b89100d558fe5/ash/shell/app_list.cc
[modify] https://crrev.com/80e1e3fadfd064342462b28f053b89100d558fe5/chrome/browser/ui/app_list/app_list_view_delegate.cc
[modify] https://crrev.com/80e1e3fadfd064342462b28f053b89100d558fe5/chrome/browser/ui/app_list/app_list_view_delegate.h
[modify] https://crrev.com/80e1e3fadfd064342462b28f053b89100d558fe5/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider.cc
[modify] https://crrev.com/80e1e3fadfd064342462b28f053b89100d558fe5/ui/app_list/app_list_view_delegate.h
[modify] https://crrev.com/80e1e3fadfd064342462b28f053b89100d558fe5/ui/app_list/test/app_list_test_view_delegate.h

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96eac6d936a4178064afe8eee7f0083e831ce176

commit 96eac6d936a4178064afe8eee7f0083e831ce176
Author: Vadim Tryshev <vadimt@google.com>
Date: Fri Aug 18 18:58:15 2017

Eliminating flicker on updating Play Store results.

Bug:  748669 
Change-Id: I82073f528c5616f7ee75c73ae2559b7912e603cd
Reviewed-on: https://chromium-review.googlesource.com/620196
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495636}
[modify] https://crrev.com/96eac6d936a4178064afe8eee7f0083e831ce176/ui/app_list/views/search_result_tile_item_view.cc

Comment 7 by vadimt@chromium.org, Aug 18 2017

Labels: Merge-Request-61 M-61
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 19 2017

Labels: -merge-approved-61
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ab7d806c79d9dd09e8c772f87634fef428660d3

commit 9ab7d806c79d9dd09e8c772f87634fef428660d3
Author: Vadim Tryshev <vadimt@google.com>
Date: Sat Aug 19 02:17:07 2017

Eliminating flicker on updating Play Store results.

TBR=vadimt@google.com

(cherry picked from commit 96eac6d936a4178064afe8eee7f0083e831ce176)

Bug:  748669 
Change-Id: I82073f528c5616f7ee75c73ae2559b7912e603cd
Reviewed-on: https://chromium-review.googlesource.com/620196
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Vadim Tryshev <vadimt@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495636}
Reviewed-on: https://chromium-review.googlesource.com/622468
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#694}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/9ab7d806c79d9dd09e8c772f87634fef428660d3/ui/app_list/views/search_result_tile_item_view.cc

Status: Fixed (was: Assigned)

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment