New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748655 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

testTelemetryUsesChromeClockDomain flaky

Project Member Reported by zakerinasab@chromium.org, Jul 25 2017

Issue description

measurements.clock_domain_test.ClockDomainTest.testTelemetryUsesChromeClockDomain is constantly flaky on Mac 10.11:

https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/15653

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=telemetry_perf_unittests&builder=chromium.mac%3AMac10.11%20Tests&tests=measurements.clock_domain_test.ClockDomainTest.testTelemetryUsesChromeClockDomain


@rnephew: please take a look at this and disable the test for Mac for now if there isn't a quick solution. Thanks.
 
ping?
Status: Started (was: Assigned)
I am going to add some logging really quick. I think I know what the problem is but I cant reproduce it locally to confirm. I believe that another test is interfering with this somehow (probably by not doing proper clean up), or this test makes some assumptions that it shouldn't about how it will be run. 
Cc: charliea@chromium.org
Cc: -charliea@chromium.org
So, I dont see any run where this doesn't pass on the 2nd retry sans a few runs where multiple tests have also failed. Is p1 really appropriate for this? Most of the redness in that test suite appears to be from time outs.
Cc: charliea@chromium.org
Didn't mean to remove him.
Summary: testTelemetryUsesChromeClockDomain flaky (was: testTelemetryUsesChromeClockDomain flaky on Mac 10.11)
This is flaky on more than just mac 10.11. I see it on windows as well:

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__1_%2F69604%2F%2B%2Frecipes%2Fsteps%2Ftelemetry_perf_unittests%2F0%2Fstdout

and mac 10.10:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_Tests%2F21371%2F%2B%2Frecipes%2Fsteps%2Ftelemetry_perf_unittests_on_Mac-10.10%2F0%2Fstdout


Running locally by itself I see no issue with this, which makes me believe even more that this is caused by interaction with other tests. I'm still waiting on a CL to land that adds logging to help confirm this.

https://chromium-review.googlesource.com/c/590101/

Comment 8 by meade@chromium.org, Jul 28 2017

Labels: -Sheriff-Chromium
I'm going to remove the sheriff label since it looks like this is being worked on.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/910f8a81e3f89e13c5bf4850e1cb6bf9a3cdcebf

commit 910f8a81e3f89e13c5bf4850e1cb6bf9a3cdcebf
Author: rnephew <rnephew@chromium.org>
Date: Fri Jul 28 06:27:06 2017

[Telemetry] Make clock_domain_test run by itself.

By adding the @decorators.Isolated decorator we can ensure that
this test runs by itself. I believe the issue with this test is that
it is seeing multiple clock sync markers in the trace, which is causing
it to fail an assert. By isolating it, it should make it so that this is
no longer an issue.

Bug:  748655 
Change-Id: I01bf75a31806d0ac53f976154fdbd014269e7a4c
Reviewed-on: https://chromium-review.googlesource.com/590366
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490299}
[modify] https://crrev.com/910f8a81e3f89e13c5bf4850e1cb6bf9a3cdcebf/tools/perf/measurements/clock_domain_test.py

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f079fe45395212445b96a16839fc05906fbafbd1

commit f079fe45395212445b96a16839fc05906fbafbd1
Author: rnephew <rnephew@chromium.org>
Date: Fri Jul 28 13:06:10 2017

[Telemetry] Add logging to clock_domain_test.

It is currently failing flakily on mac 10.11. This will output
more information upon failure that should help solve the problem.

Bug:  748655 
Change-Id: Icf7b110195367e881be7e7b5331c2161b3ea9e38
Reviewed-on: https://chromium-review.googlesource.com/590101
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490374}
[modify] https://crrev.com/f079fe45395212445b96a16839fc05906fbafbd1/tools/perf/measurements/clock_domain_test.py

Status: Fixed (was: Started)

Sign in to add a comment