Enable 'aria-valid-attribute' audit rule in MD Settings a11y tests. |
||||
Issue description
Chrome Version: 62.0.3167.0 (Developer Build) (64-bit)
OS: Linux
At the time of the bug being filed, the aXe-core accessibility audit does not support exclusion of elements that exist in the shadow DOM from the audit or from specific audit rules.
As a result, we have had to disable this rule in our Chrome MD Settings accessibility browser tests because of the false positive(s) it triggers. However, disabling this rule may cause us to miss certain violations in the future.
Once there is a way to reliably exclude the "Advanced" toggle (paper-button with id="advancedToggle"), do so and re-enable the rule.
How to reproduce the issue:
(1) Set the context of the audit in SettingsAccessibilityTest.runAudit function to try to exclude '#advancedToggle" in chrome/test/data/webui/settings/accessibility_browsertest.js
e.g.
var context = {
exclude: [['iron-iconset-svg'],['#advancedToggle']]
};
(2) build chrome with browser_tests build target
(3) run the browser_tests executable with gtest_filter="SettingsAccessibilityTest.*"
What is the expected result?
To be able to exclude the advancedToggle paper-button element from the audit for that specific rule.
What happens instead?
aXe-core only allows include-exclude of elements on light-dom.
,
Jul 26 2017
,
Aug 4 2017
To resolve this bug, I've implemented a filter for the axe audit results through which you can specify the audit rule and a selector function for what nodes to make exceptions for. https://chromium-review.googlesource.com/c/602584 is still in review.
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e8106bcb649002816db3ef70b40684ca8e75bf5 commit 3e8106bcb649002816db3ef70b40684ca8e75bf5 Author: Tina Quach <quacht@google.com> Date: Wed Aug 09 07:00:06 2017 Add ability to filter accessibility audit results. The aXe-audit sometimes has false positives, this CL allows exceptions to be filtered. It also does some refactoring and adds the aXe audit's type definitions so they may be referenced in documentation. Bug: 737739, 748632 Change-Id: Id7b9e626007b80e64261d36cdbd532b3f93e72b9 Reviewed-on: https://chromium-review.googlesource.com/602584 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#492874} [modify] https://crrev.com/3e8106bcb649002816db3ef70b40684ca8e75bf5/chrome/test/data/webui/BUILD.gn [delete] https://crrev.com/f05cf3bcebea7a5b5815337ba39e427d76dd03f7/chrome/test/data/webui/settings/accessibility_audit.js [modify] https://crrev.com/3e8106bcb649002816db3ef70b40684ca8e75bf5/chrome/test/data/webui/settings/accessibility_browsertest.js [add] https://crrev.com/3e8106bcb649002816db3ef70b40684ca8e75bf5/chrome/test/data/webui/settings/accessibility_test.js [modify] https://crrev.com/3e8106bcb649002816db3ef70b40684ca8e75bf5/chrome/test/data/webui/settings/passwords_a11y_test.js [modify] https://crrev.com/3e8106bcb649002816db3ef70b40684ca8e75bf5/third_party/axe-core/README.chromium [add] https://crrev.com/3e8106bcb649002816db3ef70b40684ca8e75bf5/third_party/axe-core/axe.d.ts
,
Aug 9 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by quacht@google.com
, Jul 25 2017