New issue
Advanced search Search tips

Issue 748630 link

Starred by 1 user
Status: Started
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature



Sign in to add a comment

Capture system and process memory metrics on crashes

Project Member Reported by siggi@chromium.org, Jul 25 2017 
If crash reports contained system and process memory metrics, it'd be easier to triage OOM bugs into different categories:
- System OOM, process reasonable
  Not actionable.
- Process OOM, system reasonable.
  Sadly unlikely to be actionable ATM, as the crash dump is unlikely to
  contain the right data.
- Unreasonable memory request.
  Actionable.

To this end, I'm adding the allocation request size (where available), the system commit size, and commit remaining, along with process private bytes etc, to crumbs on crash.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c3614ba39376d2d7e3b9d3f35d0f97087fe3ac1

commit 2c3614ba39376d2d7e3b9d3f35d0f97087fe3ac1
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Fri Aug 04 13:49:13 2017

Grab system and process memory metrics into crumbs at crash time.

Also grab the attempted allocation size when available.

Bug: 748630
Change-Id: Icdf48d6a0cebf27bab2c5965847f607966b03f50
Reviewed-on: https://chromium-review.googlesource.com/585357
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Pierre-Antoine Manzagol (departed) <manzagop@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492013}
[modify] https://crrev.com/2c3614ba39376d2d7e3b9d3f35d0f97087fe3ac1/components/browser_watcher/dump_stability_report_main_win.cc
[modify] https://crrev.com/2c3614ba39376d2d7e3b9d3f35d0f97087fe3ac1/components/browser_watcher/stability_report.proto
[modify] https://crrev.com/2c3614ba39376d2d7e3b9d3f35d0f97087fe3ac1/components/browser_watcher/stability_report_user_stream_data_source.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7900e2e33ece0d1bd5aa985a1d34809310f5c61

commit c7900e2e33ece0d1bd5aa985a1d34809310f5c61
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Fri Aug 04 19:48:13 2017

Add dumping for system memory crumbs.

R=manzagop@chromium.org

Bug: 748630
Change-Id: Iaf1744018f254b1965b9a2eb3419d827190f6efc
Reviewed-on: https://chromium-review.googlesource.com/602494
Reviewed-by: Pierre-Antoine Manzagol (departed) <manzagop@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492104}
[modify] https://crrev.com/c7900e2e33ece0d1bd5aa985a1d34809310f5c61/components/browser_watcher/dump_stability_report_main_win.cc
►

Sign in to add a comment