New issue
Advanced search Search tips

Issue 748628 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Switch the default layout test results viewer

Project Member Reported by qyears...@chromium.org, Jul 25 2017

Issue description

Initial thread on blink-infra: https://groups.google.com/a/chromium.org/forum/#!topic/blink-infra/IG3hICO-Wkg

Related bug for the new results viewer page: https://crbug.com/726520.
 
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/585390/
Owner: ----
Status: Available (was: Started)
Based on feedback on blink-dev, I think it's probably prudent to keep the same default for now, and revisit this sometime in the future.

Some differences between the two pages that we may want to address before considering switching:

> - Keyboard shortcuts (j, k, e, c, f).  More generally, the new results page requires a lot more clicking.
> - Information about the type of failure (text diff, image diff, ref diff, etc.)
> - The ability to see expected and actual results side-by-side, for visual comparison
> - The pretty-diff view
> - The pane with two-second toggling between expected and actual results
> - The pixel-zoom behavior when hovering over an image diff (https://screenshot.googleplex.com/wG4oCHjXJdT)
> - The ability to flag a subset of tests and then copy the names of those tests in the "Flagged Tests" section
Cc: szager@chromium.org
Owner: qyears...@chromium.org
Status: Assigned (was: Available)
Blink-dev thread in #2 has now been updated. I think Aleks added the above features; if it's alright, I'll make the switch next week?
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/659149262f92954038e0317a5f372aee0ab57565

commit 659149262f92954038e0317a5f372aee0ab57565
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Nov 17 17:54:27 2017

Switch the default layout test results viewer page

This CL:
 - renames "test-expectations.html" so that it is called "results.html"
 - renames the old results.html to be "legacy-results.html"

blink-dev thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9NFDSTEzcd4

Bug:  748628 
Change-Id: Id8293ed24f680b71cf1bdb3e134cdb130154ee14
Reviewed-on: https://chromium-review.googlesource.com/775973
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517462}
[modify] https://crrev.com/659149262f92954038e0317a5f372aee0ab57565/third_party/WebKit/LayoutTests/NeverFixTests
[rename] https://crrev.com/659149262f92954038e0317a5f372aee0ab57565/third_party/WebKit/LayoutTests/fast/harness/legacy-results-expected.txt
[add] https://crrev.com/659149262f92954038e0317a5f372aee0ab57565/third_party/WebKit/LayoutTests/fast/harness/legacy-results.html
[rename] https://crrev.com/659149262f92954038e0317a5f372aee0ab57565/third_party/WebKit/LayoutTests/fast/harness/resources/legacy-results-test.js
[modify] https://crrev.com/659149262f92954038e0317a5f372aee0ab57565/third_party/WebKit/LayoutTests/fast/harness/results.html
[delete] https://crrev.com/010dce344ac088903a108aeec3ad27b2587fdca3/third_party/WebKit/LayoutTests/fast/harness/test-expectations.html
[modify] https://crrev.com/659149262f92954038e0317a5f372aee0ab57565/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 30

Sign in to add a comment