New issue
Advanced search Search tips

Issue 748623 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

run-webkit-tests: Remove flag "--full-results-html".

Project Member Reported by qyears...@chromium.org, Jul 25 2017 
This flag now no longer determines whether the full results JSON is written, as the flag name implies. In fact, the full results JSON is always written now, and used by the new results viewer page.

Now this flag only affects whether the results page is opened in the browser:
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py?l=231

So I think it's safe to remove this flag, but first we'll want to remove it from the list of flags passed when invoking run-webkit-tests on the bots, where it shouldn't have any effect anyway since --no-show-results is also passed.

Comment 1 by qyears...@chromium.org, Jul 25 2017 

Subtasks here:
 1. Remove the invocation on swarming jobs
 2. Remove the invocation on non swarming jobs
 3. Remove the flag itself

Comment 2 by qyears...@chromium.org, Jul 26 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/db92d12b9af843d9cb8e80eca1fce991cf08c60c

commit db92d12b9af843d9cb8e80eca1fce991cf08c60c
Author: Quinten Yearsley <qyearsley@google.com>
Date: Wed Jul 26 23:42:39 2017

Remove --full-results-html from layout tests invocation

This flag should no longer have any effect and could be removed.

Bug:  748623 
Change-Id: If2c9bbf04c420692cac0f48e02304002e891b183
Reviewed-on: https://chromium-review.googlesource.com/587030
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/chromium_trybot.expected/non_cq_blink_tryjob.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/webkit_tests_interrupted.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/webkit_tests_unexpected_error.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_pass.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipe_modules/chromium_tests/tests/steps/blink_test.expected/android.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipe_modules/chromium_tests/tests/steps/blink_test.expected/unexpected_flakes.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/chromium_trybot.expected/add_layout_tests_via_manual_diff_inspection.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_fail.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipe_modules/chromium_tests/tests/steps/blink_test.expected/win.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipe_modules/chromium_tests/tests/steps/blink_test.expected/big.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json
[modify] https://crrev.com/db92d12b9af843d9cb8e80eca1fce991cf08c60c/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c1b8850083719a18087a9764959d8b9bd0855a4

commit 4c1b8850083719a18087a9764959d8b9bd0855a4
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu Aug 03 00:05:46 2017

Remove --full-results-html from rwt invocation for swarming

This flag shouldn't affect test runs here; see bug.

Bug:  748623 
Change-Id: Ic4937b1ad174c60bc758e22851177d69105293a0
Reviewed-on: https://chromium-review.googlesource.com/585359
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491562}
[modify] https://crrev.com/4c1b8850083719a18087a9764959d8b9bd0855a4/testing/buildbot/gn_isolate_map.pyl

Comment 6 by qyears...@chromium.org, Aug 7 2017

Status: Fixed (was: Started)
►

Sign in to add a comment