New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748620 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 735999



Sign in to add a comment

Update the opacity of the app list during dragging

Project Member Reported by minch@chromium.org, Jul 25 2017

Issue description

Update the opacity of app list background and all the items in the app list during dragging fullscreen app list from the shelf.

1) Only tablet mode. Swiping up on the shelf to open the fullscreen app list.
2) Update the background opacity of app list based on the shelf's original opacity. Changes gradually to its final opacity (0.8 currently). The relationship,

Applist background opacity = (Opacity of app list) * t + (1 - t) * (opacity of shelf)
t = gesture_drag_amount / (3.0 * shelfsize)
"3.0" here because the shelf is visible, should subtract this one's size.

3) Update opacity of all the items in the app list, includes,
searchbox view,
suggested_indicator,
suggested_apps,
all_apps_indicator,
all apps in the first page(since will only show the first page during dragging).
page switcher if one exists

The opacity of the items changes gradually to its final opacity (1.0).
Formula of the current opacity,
Opacity of item = (work_area_bottom - centroid of the item's bounds in screen) / (2.0 * shelfsize)


 

Comment 1 by minch@chromium.org, Jul 25 2017

Blocking: 735999

Comment 2 by minch@chromium.org, Jul 26 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eafaa52e484c5ef28f4b24ee5ea9262175cb4122

commit eafaa52e484c5ef28f4b24ee5ea9262175cb4122
Author: MinChen <minch@chromium.org>
Date: Mon Jul 31 18:32:52 2017

Update opacity of the fullscreen app list during dragging from shelf.

1. Update the app list background opacity based on the shelf's original opacity.
Shelf changes to fully transparent if app list is opened.
Relationship:
    Applist background opacity = (Opacity of app list) * t + (1 - t) * (opacity of shelf)
    t = gesture_drag_amount / (3.0 * shelfsize)

2. Update the opacity of all the items in the app list.
Includeing, searchbox view, suggested_apps_indicator, suggested_apps, all_apps_indicator,
            all apps in the first page, page switcher
Formula:
Opacity of item = (work_area_bottom - centroid of the item's screen bounds) / (2.0 * shelfsize)

Bug:  748620 
Change-Id: Ia1fc25628423fcc1ffad666319e04292837aae2c
Reviewed-on: https://chromium-review.googlesource.com/585398
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490786}
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ash/shell.cc
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ash/shell.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ash/shell/example_app_list_presenter.cc
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ash/shell/example_app_list_presenter.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/chrome/browser/ui/ash/app_list/app_list_presenter_service.cc
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/chrome/browser/ui/ash/app_list/app_list_presenter_service.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/presenter/app_list.cc
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/presenter/app_list.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/presenter/app_list_presenter.mojom
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/presenter/app_list_presenter_impl.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/presenter/test/test_app_list_presenter.cc
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/presenter/test/test_app_list_presenter.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/apps_grid_view.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/indicator_chip_view.cc
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/indicator_chip_view.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/page_switcher.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/page_switcher_horizontal.cc
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/page_switcher_horizontal.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/page_switcher_vertical.cc
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/page_switcher_vertical.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/search_box_view.h
[modify] https://crrev.com/eafaa52e484c5ef28f4b24ee5ea9262175cb4122/ui/app_list/views/search_result_tile_item_view.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02f471a26b9a91fddddbca87de818f8b1d48d6b4

commit 02f471a26b9a91fddddbca87de818f8b1d48d6b4
Author: MinChen <minch@chromium.org>
Date: Wed Aug 02 23:42:14 2017

Updates opacity of app list when dragging opened app list.

Changes,
Updates opacity of app list if dragging happened on the opened app list.
Updates opacity of start page in peeking state during dragging.
Since each page of app list can be dragged, remove the first page
restriction in UpdateOpacity.

After changes, when dragging the opened app list. The opacity of app
list will also updates during dragging.

Bug:  748620 
Change-Id: Ic93edcaf28e422117bbdd3a5fa100ebcd5c9842d
Reviewed-on: https://chromium-review.googlesource.com/594682
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491554}
[modify] https://crrev.com/02f471a26b9a91fddddbca87de818f8b1d48d6b4/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/02f471a26b9a91fddddbca87de818f8b1d48d6b4/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/02f471a26b9a91fddddbca87de818f8b1d48d6b4/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/02f471a26b9a91fddddbca87de818f8b1d48d6b4/ui/app_list/views/expand_arrow_view.cc
[modify] https://crrev.com/02f471a26b9a91fddddbca87de818f8b1d48d6b4/ui/app_list/views/start_page_view.cc
[modify] https://crrev.com/02f471a26b9a91fddddbca87de818f8b1d48d6b4/ui/app_list/views/start_page_view.h

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/943f4a7b631884172a5d4512d6cd86e0f3177534

commit 943f4a7b631884172a5d4512d6cd86e0f3177534
Author: Maajid <maajid@chromium.org>
Date: Thu Aug 03 21:54:48 2017

Update opacity of the fullscreen app list during dragging from shelf.

1. Update the app list background opacity based on the shelf's original opacity.
Shelf changes to fully transparent if app list is opened.
Relationship:
    Applist background opacity = (Opacity of app list) * t + (1 - t) * (opacity of shelf)
    t = gesture_drag_amount / (3.0 * shelfsize)

2. Update the opacity of all the items in the app list.
Includeing, searchbox view, suggested_apps_indicator, suggested_apps, all_apps_indicator,
            all apps in the first page, page switcher
Formula:
Opacity of item = (work_area_bottom - centroid of the item's screen bounds) / (2.0 * shelfsize)

TBR=minch@chromium.org

(cherry picked from commit eafaa52e484c5ef28f4b24ee5ea9262175cb4122)

Bug:  748620 
Change-Id: Ia1fc25628423fcc1ffad666319e04292837aae2c
Reviewed-on: https://chromium-review.googlesource.com/585398
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490786}
Reviewed-on: https://chromium-review.googlesource.com/600859
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#290}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ash/shell.cc
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ash/shell.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ash/shell/example_app_list_presenter.cc
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ash/shell/example_app_list_presenter.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/chrome/browser/ui/ash/app_list/app_list_presenter_service.cc
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/chrome/browser/ui/ash/app_list/app_list_presenter_service.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/presenter/app_list.cc
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/presenter/app_list.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/presenter/app_list_presenter.mojom
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/presenter/app_list_presenter_impl.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/presenter/test/test_app_list_presenter.cc
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/presenter/test/test_app_list_presenter.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/apps_grid_view.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/indicator_chip_view.cc
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/indicator_chip_view.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/page_switcher.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/page_switcher_horizontal.cc
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/page_switcher_horizontal.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/page_switcher_vertical.cc
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/page_switcher_vertical.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/search_box_view.h
[modify] https://crrev.com/943f4a7b631884172a5d4512d6cd86e0f3177534/ui/app_list/views/search_result_tile_item_view.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/defb2350a95538d0bb9f1c03789d1393850e8879

commit defb2350a95538d0bb9f1c03789d1393850e8879
Author: Maajid <maajid@chromium.org>
Date: Thu Aug 03 22:37:39 2017

Updates opacity of app list when dragging opened app list.

Changes,
Updates opacity of app list if dragging happened on the opened app list.
Updates opacity of start page in peeking state during dragging.
Since each page of app list can be dragged, remove the first page
restriction in UpdateOpacity.

After changes, when dragging the opened app list. The opacity of app
list will also updates during dragging.

TBR=minch@chromium.org

(cherry picked from commit 02f471a26b9a91fddddbca87de818f8b1d48d6b4)

Bug:  748620 
Change-Id: Ic93edcaf28e422117bbdd3a5fa100ebcd5c9842d
Reviewed-on: https://chromium-review.googlesource.com/594682
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491554}
Reviewed-on: https://chromium-review.googlesource.com/601091
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#297}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/defb2350a95538d0bb9f1c03789d1393850e8879/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/defb2350a95538d0bb9f1c03789d1393850e8879/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/defb2350a95538d0bb9f1c03789d1393850e8879/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/defb2350a95538d0bb9f1c03789d1393850e8879/ui/app_list/views/expand_arrow_view.cc
[modify] https://crrev.com/defb2350a95538d0bb9f1c03789d1393850e8879/ui/app_list/views/start_page_view.cc
[modify] https://crrev.com/defb2350a95538d0bb9f1c03789d1393850e8879/ui/app_list/views/start_page_view.h

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac439ba4a2209e0695c52e23ab49c6917e5c9326

commit ac439ba4a2209e0695c52e23ab49c6917e5c9326
Author: MinChen <minch@chromium.org>
Date: Fri Aug 04 00:43:35 2017

Restores the background of app list at the end of gesture dragging.

Bug:  748620 
Change-Id: I37cb0ed1288b77044909bc03119f221acb1552cc
Reviewed-on: https://chromium-review.googlesource.com/601327
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491893}
[modify] https://crrev.com/ac439ba4a2209e0695c52e23ab49c6917e5c9326/ui/app_list/views/app_list_view.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4921860c4ca8d35ec36482fefe114552590aaea5

commit 4921860c4ca8d35ec36482fefe114552590aaea5
Author: Maajid <maajid@chromium.org>
Date: Mon Aug 07 21:36:02 2017

Restores the background of app list at the end of gesture dragging.

TBR=minch@chromium.org

(cherry picked from commit ac439ba4a2209e0695c52e23ab49c6917e5c9326)

Bug:  748620 
Change-Id: I37cb0ed1288b77044909bc03119f221acb1552cc
Reviewed-on: https://chromium-review.googlesource.com/601327
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491893}
Reviewed-on: https://chromium-review.googlesource.com/604479
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#371}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/4921860c4ca8d35ec36482fefe114552590aaea5/ui/app_list/views/app_list_view.cc

Comment 9 by minch@chromium.org, Aug 8 2017

Status: Fixed (was: Started)

Sign in to add a comment