Issue metadata
Sign in to add a comment
|
[MacViews] Permission bubble positioned too far to the right in RTL mode |
||||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3166.0 OS: macOS 10.12 What steps will reproduce the problem? (1) Launch Chrome from command line with "-NSForceRightToLeftWritingDirection YES" "-AppleTextDirection YES" --force-ui-direction=rtl --enable-features=MacRTL (2) Go to permission.site (3) Click the Location button to get the location permission prompt The permission bubble is too far to the right (see the attached screenshot). I don't know if this is Mac-specific or not. -> ellyjones@ for triage.
,
Jul 26 2017
This is due to r435207. I'll fix up permission bubbles so that Issue 740827 has the correct RTL behaviour for permission bubbles. For location decorations and others, it's likely --enable-features=MacRTL will be default-enabled before --secondary-ui-md, so we can just revert r435207 and whatever I patch I'm about to do to fix permission bubbles.
,
Jul 26 2017
(See also Issue 748615 for Cocoa bubbles)
,
Jul 26 2017
,
Jul 26 2017
screenshots for https://chromium-review.googlesource.com/584653
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86aeb70b65bcd24058ab6f9f8038a8d8ea91de34 commit 86aeb70b65bcd24058ab6f9f8038a8d8ea91de34 Author: Trent Apted <tapted@chromium.org> Date: Wed Jul 26 02:01:28 2017 Mac: Fix toolkit-views permission bubbles in RTL. The default is not to flip while we wait for --enable-features=MacRTL to launch. But toolkit-views permission bubbles (only) on Mac may launch before that, so ensure they flip appropriately. Bug: 748616 Change-Id: I687fea0a4d6d4777b03ecaf4f56a369b4fad3837 Reviewed-on: https://chromium-review.googlesource.com/584653 Reviewed-by: Raymes Khoury <raymes@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#489527} [modify] https://crrev.com/86aeb70b65bcd24058ab6f9f8038a8d8ea91de34/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
,
Aug 3 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by shrike@chromium.org
, Jul 25 201723.8 KB
23.8 KB View Download