Issue metadata
Sign in to add a comment
|
[Mac] Permission bubble is LTR in RTL mode |
||||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3166.0 OS: macOS 10.12 What steps will reproduce the problem? (1) Launch Chrome from command line with "-NSForceRightToLeftWritingDirection YES" "-AppleTextDirection YES" --force-ui-direction=rtl --enable-features=MacRTL (2) Go to permission.site (3) Click the Location button to get the location permission prompt What is the expected result? The permission bubble should be RTL What happens instead? The permission bubble is LTR. The bubble is RTL in MacViews (although it has other problems). I don't know if the plan should be to fix all native Mac secondary UI (if there other problematic dialogs) or to wait for MacView secondary UI, which has no ship date at this point.
,
Jul 25 2017
I see that tapted@ flipped the switch on making permission bubbles default to Views on macOS (Issue 740827). Permission bubbles are laid out correctly in MacViews but their positioning is wrong ( Issue 748616 ), so that will need to be fixed for the switch to RTL.
,
Jul 26 2017
kMirrorBubbleArrowInRTLByDefault just sets the default. It would be good to avoid plumbing the runtime variable into toolkit-views if it's temporary (i.e. while waiting for --enable-features=MacRTL to be default-enabled). I'll pick up Issue 748616 to fix the toolkit-views bubbles which are currently default on trunk/m62. If Issue 740827 launches in m62, the bug here (for Cocoa permission bubbles) will be obsolete. But if we want to fix the RTL layout of other Cocoa bubbles, I don't have a neat solution apart from flipping --secondary-ui-md on Mac.
,
Jul 26 2017
Whoops. I thought this one was already done in Cocoa and the recent CL enabled it by default. Sorry for the confusion!
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a01c45fc8e35724fb57b66108e1c1ea77774a75 commit 1a01c45fc8e35724fb57b66108e1c1ea77774a75 Author: Leonard Grey <lgrey@chromium.org> Date: Wed Jul 26 18:37:26 2017 [Mac] Flip permission bubble in RTL Bug: 748615 Change-Id: I2fddf4293737f1669913fa7e097f8299918327b4 Reviewed-on: https://chromium-review.googlesource.com/586644 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#489708} [modify] https://crrev.com/1a01c45fc8e35724fb57b66108e1c1ea77774a75/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm
,
Jul 27 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgrey@chromium.org
, Jul 25 2017