[iOS] Typo to check which iOS version (between 10 and 11) |
|||||
Issue descriptionWhile fixing an ugly bug, instead of checking for iOS 11, I checked for iOS 10: https://cs.chromium.org/chromium/src/components/signin/ios/browser/account_consistency_service.mm?q=account_consist&sq=package:chromium&l=423 which should have matched with: https://cs.chromium.org/chromium/src/components/signin/ios/browser/account_consistency_service.mm?q=account_consist&sq=package:chromium&l=398 The right version is base::ios::IsRunningOnIOS11OrLater(). This bug has been introduced with crrev.com/c/577807
,
Jul 26 2017
I didn't try, but as far as I know when calling -[UIView removeFromSuperview] for a view that is not in a view, it does nothing. There is no crash.
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bd91a687e5eead254808a07f4b8741bf06f864e commit 7bd91a687e5eead254808a07f4b8741bf06f864e Author: Jérôme Lebel <jlebel@chromium.org> Date: Wed Jul 26 09:45:57 2017 Typo between IsRunningOnIOS11OrLater() and IsRunningOnIOS10OrLater() Hack introduced for iOS 11 to fix the issue related to WKWebView which has to be part of the view hierarchy. This hack should be run only on iOS 11, and not iOS 10. Bug introduced with crrev.com/b/577807 Bug: 748580 Change-Id: If133cfbf345961204fdae0773bc728898a2c7284 Reviewed-on: https://chromium-review.googlesource.com/584878 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#489589} [modify] https://crrev.com/7bd91a687e5eead254808a07f4b8741bf06f864e/components/signin/ios/browser/account_consistency_service.mm
,
Jul 26 2017
,
Jul 26 2017
,
Jul 26 2017
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e978f217ac595bb58ead87aa32985e21f74871e commit 5e978f217ac595bb58ead87aa32985e21f74871e Author: Jérôme Lebel <jlebel@chromium.org> Date: Thu Jul 27 11:22:32 2017 Typo between IsRunningOnIOS11OrLater() and IsRunningOnIOS10OrLater() Hack introduced for iOS 11 to fix the issue related to WKWebView which has to be part of the view hierarchy. This hack should be run only on iOS 11, and not iOS 10. Bug introduced with crrev.com/b/577807 TBR=jlebel@chromium.org (cherry picked from commit 7bd91a687e5eead254808a07f4b8741bf06f864e) Bug: 748580 Change-Id: If133cfbf345961204fdae0773bc728898a2c7284 Reviewed-on: https://chromium-review.googlesource.com/584878 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489589} Reviewed-on: https://chromium-review.googlesource.com/589171 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#76} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/5e978f217ac595bb58ead87aa32985e21f74871e/components/signin/ios/browser/account_consistency_service.mm |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by msarda@chromium.org
, Jul 26 2017