New issue
Advanced search Search tips

Issue 748579 link

Starred by 2 users
Status: Fixed
Owner:
lgrey@chromium.org
Closed: Sep 26
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Mac] Extension bubble animates in from middle of browser window in RTL

Project Member Reported by shrike@chromium.org, Jul 25 2017 
Chrome Version: 62.0.3166.0
OS: macOS 10.12

What steps will reproduce the problem?
(1) Launch Chrome from command line with "-NSForceRightToLeftWritingDirection YES" "-AppleTextDirection YES" --force-ui-direction=rtl --enable-features=MacRTL
(2) Click the BeyondCorp extension icon in the toolbar

What is the expected result?
The extension bubble should fade in at its final location

What happens instead?
The extension bubble animates in from the middle of the screen to its final location.

You'll see this the third time I click the bubble in the screencast. The other times the final layout is broken (the bubble is too large for the content), or the behavior is just weird.
BeyondCorpBubble.mov
1.5 MB Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dfef275f5992064057f4c6ad20c1a48bf575eab

commit 9dfef275f5992064057f4c6ad20c1a48bf575eab
Author: Leonard Grey <lgrey@chromium.org>
Date: Mon Aug 28 15:25:23 2017

[Mac] RTL-support for resizable extension bubbles

Bug:  748579 ,  748578 
Change-Id: Iec3f43459d7a62e1be19cb44b828594eedb8866a
Reviewed-on: https://chromium-review.googlesource.com/638133
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497763}
[modify] https://crrev.com/9dfef275f5992064057f4c6ad20c1a48bf575eab/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
[modify] https://crrev.com/9dfef275f5992064057f4c6ad20c1a48bf575eab/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

Comment 2 by robliao@chromium.org, Sep 25 

Triage: Is this fixed?

Comment 3 by lgrey@chromium.org, Sep 26

Status: Fixed (was: Assigned)
►

Sign in to add a comment