New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 748569 link

Starred by 1 user
Status: Fixed
Owner:
mlippautz@chromium.org
Closed: Aug 2017
Cc:
cbruni@chromium.org
mythria@chromium.org
u...@chromium.org
█ hpayer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Reuse GCTracer scopes in RCS

Project Member Reported by mlippautz@chromium.org, Jul 25 2017 
Currently we have a regular GC bucket which also gets used for memory-reducing GCs, which can also be idle GCs. 

This creates noise as it basically means that GC bucket will regress as soon as we add one more of those GCs.

We should have a separate bucket in RCS and properly distinguish them. This way the regular GC bucket is also more actionable as we only include latency-critical GCs.

Comment 1 by mlippautz@chromium.org, Jul 25 2017

Summary: Distinguish latency-critical from memory reducing GCs on RCS (was: Distinguish latency-critical from memory reducing GCs on RCR)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/481c17050525594b921ad2039bcddac37496ba63

commit 481c17050525594b921ad2039bcddac37496ba63
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue Aug 01 14:23:22 2017

[RCS] Reuse GCTracer scopes in RCS

This makes all the information that is present for GCTracer also
available to RCS.

Bug:  chromium:748569 
Change-Id: Ie7e8c3770b81ab1321cad08f6954492b72ef0514
Reviewed-on: https://chromium-review.googlesource.com/585427
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47043}
[modify] https://crrev.com/481c17050525594b921ad2039bcddac37496ba63/src/counters.cc
[modify] https://crrev.com/481c17050525594b921ad2039bcddac37496ba63/src/counters.h
[modify] https://crrev.com/481c17050525594b921ad2039bcddac37496ba63/src/heap-symbols.h
[modify] https://crrev.com/481c17050525594b921ad2039bcddac37496ba63/src/heap/gc-tracer.cc
[modify] https://crrev.com/481c17050525594b921ad2039bcddac37496ba63/src/heap/gc-tracer.h
[modify] https://crrev.com/481c17050525594b921ad2039bcddac37496ba63/src/heap/heap.cc
[modify] https://crrev.com/481c17050525594b921ad2039bcddac37496ba63/src/heap/incremental-marking-job.cc
[modify] https://crrev.com/481c17050525594b921ad2039bcddac37496ba63/src/heap/incremental-marking.cc
[modify] https://crrev.com/481c17050525594b921ad2039bcddac37496ba63/src/heap/spaces.cc
[modify] https://crrev.com/481c17050525594b921ad2039bcddac37496ba63/tools/callstats.html
[modify] https://crrev.com/481c17050525594b921ad2039bcddac37496ba63/tools/callstats.py

Comment 3 by mlippautz@chromium.org, Aug 1 2017

Status: Started (was: Assigned)
Summary: Reuse GCTracer scopes in RCS (was: Distinguish latency-critical from memory reducing GCs on RCS)
After some offline discussion we decided that the right thing would be to add GC metrics to these benchmarks as they would properly expose different GC types and counts.

This bug is used to track the usage of GCTracer scopes in RCS.

Comment 4 by mlippautz@chromium.org, Aug 4 2017

Status: Fixed (was: Started)
RCS now supports the scopes, see e.g.
  https://chromeperf.appspot.com/report?sid=8be7f2afaefc756a9f45401f543a9f51a1f6804294ca462d8c3dc72f9726deb1
►

Sign in to add a comment