New issue
Advanced search Search tips

Issue 748568 link

Starred by 1 user
Status: Fixed
Owner:
borisv@chromium.org
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

base::UnixDomainSocket class does not support Mac

Project Member Reported by borisv@chromium.org, Jul 25 2017 
Chrome Version: 62.0.3165.0
OS: OS X

This is internal code suggestion. While implementing out of process memory profiler, we needed to use sockets for Linux and Mac, but we noticed that base::UnixDomainSocket class, which provides such functionality supports only linux. The class can be updated with minor changes to support Mac too.

It is possible that there are other places in the code where Mac is special-cased for that reason.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ecb49e3c2be8e2abaed6f045735114f1911a515

commit 8ecb49e3c2be8e2abaed6f045735114f1911a515
Author: Boris Vidolov <borisv@chromium.org>
Date: Wed Jul 26 06:35:46 2017

Mac support in UnixDomainSocket.

Change-Id: Iaf58f0894e02d9b9b360fde2ad597eaf23fbc668

BUG= 748568 
TBR=jln@chromium.org,bradnelson@chromium.org,asvitkine@chromium.org,jochen@chromium.org,dglazkov@chromium.org

Change-Id: Iaf58f0894e02d9b9b360fde2ad597eaf23fbc668
Reviewed-on: https://chromium-review.googlesource.com/580543
Commit-Queue: Boris Vidolov <borisv@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489567}
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/base/BUILD.gn
[rename] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/base/posix/unix_domain_socket.cc
[rename] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/base/posix/unix_domain_socket.h
[rename] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/base/posix/unix_domain_socket_unittest.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/chrome/common/profiling/memlog_sender_pipe_posix.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/chrome/profiling/memlog_receiver_pipe_posix.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/components/nacl/loader/nacl_helper_linux.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/components/nacl/zygote/nacl_fork_delegate_linux.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/content/browser/renderer_host/sandbox_ipc_linux.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/content/browser/zygote_host/zygote_communication_linux.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/content/browser/zygote_host/zygote_host_impl_linux.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/content/child/child_process_sandbox_support_impl_linux.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/content/child/child_process_sandbox_support_impl_shm_linux.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/content/common/font_config_ipc_linux.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/content/common/send_zygote_child_ping_linux.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/content/public/browser/arc_tracing_agent.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/content/zygote/zygote_linux.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/content/zygote/zygote_main_linux.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/sandbox/linux/integration_tests/namespace_unix_domain_socket_unittest.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/sandbox/linux/syscall_broker/broker_client.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/sandbox/linux/syscall_broker/broker_host.cc
[modify] https://crrev.com/8ecb49e3c2be8e2abaed6f045735114f1911a515/sandbox/linux/syscall_broker/broker_process_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8ac35950fdea5d0292544618a23709d2558a12e

commit c8ac35950fdea5d0292544618a23709d2558a12e
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Jul 26 21:32:52 2017

fuchsia: Re-exclude posix/unix_domain_socket

https://chromium-review.googlesource.com/c/580543 semi-accidentally
started including this in the Fuchsia build by renaming it from _linux
to generic posix/. It may be usable on Fuchsia too, but for now
re-exclude it to make the build compile again.

NOTRY=true

Bug: 706592, 738275,  748568 
Change-Id: I46c33bec5736a9ae2b3aa3afbc52aa0752270ad5
Reviewed-on: https://chromium-review.googlesource.com/587091
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489760}
[modify] https://crrev.com/c8ac35950fdea5d0292544618a23709d2558a12e/base/BUILD.gn

Comment 3 by borisv@chromium.org, Jul 31 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment