New issue
Advanced search Search tips

Issue 748552 link

Starred by 1 user
Status: Fixed
Owner:
tmartino@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[WebPayments] Clicking on selected row should go back

Project Member Reported by tmartino@chromium.org, Jul 25 2017 
Currently, clicking on a row which is already selected is a no-op. This is annoying. It requires the user to go the "correct" route, rather that just understanding that, clearly they want to keep the selected address. Clicking on the selected row should instead be handled the same as clicking Back.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90a73c37c47e79d66c2979cca5cf78de94915cd8

commit 90a73c37c47e79d66c2979cca5cf78de94915cd8
Author: Tommy Martino <tmartino@chromium.org>
Date: Thu Aug 03 15:53:58 2017

[WebPayments] Clicking selected row goes back

Changing behavior when clicking on the currently selected item in an
ItemList. Was a no-op; now goes back to the main sheet.

Bug:  748552 
Change-Id: I43f716145c059b6d95d5f01526b1224528fb0ad3
Reviewed-on: https://chromium-review.googlesource.com/585370
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491751}
[modify] https://crrev.com/90a73c37c47e79d66c2979cca5cf78de94915cd8/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/90a73c37c47e79d66c2979cca5cf78de94915cd8/chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc
[modify] https://crrev.com/90a73c37c47e79d66c2979cca5cf78de94915cd8/chrome/browser/ui/views/payments/payment_request_item_list.cc
[modify] https://crrev.com/90a73c37c47e79d66c2979cca5cf78de94915cd8/chrome/browser/ui/views/payments/payment_request_item_list.h
[modify] https://crrev.com/90a73c37c47e79d66c2979cca5cf78de94915cd8/chrome/browser/ui/views/payments/payment_request_item_list_unittest.cc
[modify] https://crrev.com/90a73c37c47e79d66c2979cca5cf78de94915cd8/chrome/browser/ui/views/payments/profile_list_view_controller.cc
[modify] https://crrev.com/90a73c37c47e79d66c2979cca5cf78de94915cd8/chrome/browser/ui/views/payments/shipping_option_view_controller.cc

Comment 2 by tmartino@chromium.org, Aug 3 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45608e0c526e4aca531581136195c4bc976edc43

commit 45608e0c526e4aca531581136195c4bc976edc43
Author: Luna Lu <loonybear@chromium.org>
Date: Thu Aug 03 18:01:34 2017

Revert "[WebPayments] Clicking selected row goes back"

This reverts commit 90a73c37c47e79d66c2979cca5cf78de94915cd8.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [WebPayments] Clicking selected row goes back
> 
> Changing behavior when clicking on the currently selected item in an
> ItemList. Was a no-op; now goes back to the main sheet.
> 
> Bug:  748552 
> Change-Id: I43f716145c059b6d95d5f01526b1224528fb0ad3
> Reviewed-on: https://chromium-review.googlesource.com/585370
> Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
> Commit-Queue: Tommy Martino <tmartino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491751}

TBR=anthonyvd@chromium.org,tmartino@chromium.org

Change-Id: I8a5d7de3da2f0e7f47bff11e9c6980e31590c38d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  748552 
Reviewed-on: https://chromium-review.googlesource.com/600847
Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491790}
[modify] https://crrev.com/45608e0c526e4aca531581136195c4bc976edc43/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/45608e0c526e4aca531581136195c4bc976edc43/chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc
[modify] https://crrev.com/45608e0c526e4aca531581136195c4bc976edc43/chrome/browser/ui/views/payments/payment_request_item_list.cc
[modify] https://crrev.com/45608e0c526e4aca531581136195c4bc976edc43/chrome/browser/ui/views/payments/payment_request_item_list.h
[modify] https://crrev.com/45608e0c526e4aca531581136195c4bc976edc43/chrome/browser/ui/views/payments/payment_request_item_list_unittest.cc
[modify] https://crrev.com/45608e0c526e4aca531581136195c4bc976edc43/chrome/browser/ui/views/payments/profile_list_view_controller.cc
[modify] https://crrev.com/45608e0c526e4aca531581136195c4bc976edc43/chrome/browser/ui/views/payments/shipping_option_view_controller.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68b34d596842d58dcbbbb96c16aa2ff3b014f652

commit 68b34d596842d58dcbbbb96c16aa2ff3b014f652
Author: Tommy Martino <tmartino@chromium.org>
Date: Wed Aug 09 19:08:38 2017

Reland "[WebPayments] Clicking selected row goes back"

This is a reland of 90a73c37c47e79d66c2979cca5cf78de94915cd8
Original change's description:
> [WebPayments] Clicking selected row goes back
> 
> Changing behavior when clicking on the currently selected item in an
> ItemList. Was a no-op; now goes back to the main sheet.
> 
> Bug:  748552 
> Change-Id: I43f716145c059b6d95d5f01526b1224528fb0ad3
> Reviewed-on: https://chromium-review.googlesource.com/585370
> Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
> Commit-Queue: Tommy Martino <tmartino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491751}

Bug:  748552 
Change-Id: I3272409604dbbaf8d6dc317d6bad96f9ced40320
Reviewed-on: https://chromium-review.googlesource.com/606127
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493084}
[modify] https://crrev.com/68b34d596842d58dcbbbb96c16aa2ff3b014f652/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/68b34d596842d58dcbbbb96c16aa2ff3b014f652/chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc
[modify] https://crrev.com/68b34d596842d58dcbbbb96c16aa2ff3b014f652/chrome/browser/ui/views/payments/payment_request_item_list.cc
[modify] https://crrev.com/68b34d596842d58dcbbbb96c16aa2ff3b014f652/chrome/browser/ui/views/payments/payment_request_item_list.h
[modify] https://crrev.com/68b34d596842d58dcbbbb96c16aa2ff3b014f652/chrome/browser/ui/views/payments/payment_request_item_list_unittest.cc
[modify] https://crrev.com/68b34d596842d58dcbbbb96c16aa2ff3b014f652/chrome/browser/ui/views/payments/profile_list_view_controller.cc
[modify] https://crrev.com/68b34d596842d58dcbbbb96c16aa2ff3b014f652/chrome/browser/ui/views/payments/shipping_option_view_controller.cc
►

Sign in to add a comment