New issue
Advanced search Search tips

Issue 748548 link

Starred by 1 user
Status: Fixed
Owner:
cblume@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 848388



Sign in to add a comment

Cannot compile with enable_vulkan=true

Reported by devinlam...@gmail.com, Jul 25 2017 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.72 Safari/537.36

Steps to reproduce the problem:
1. Compile chromium with enable_vulkan=true
2. Compile fails
3. 

What is the expected behavior?
Chromium will compile successfully

What went wrong?
[13/21121] LINK(DLL) vulkan_wrapper.dll vulkan_wrapper.dll.lib
FAILED: vulkan_wrapper.dll vulkan_wrapper.dll.lib
E:/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /IMPLIB:./vulkan_wrapper.dll.lib /DLL /OUT:./vulkan_wrapper.dll /PDB:./vulkan_wrapper.dll.pdb @./vulkan_wrapper.dll.rsp
LINK : warning LNK4001: no object files specified; libraries used
LINK : error LNK1218: warning treated as error; no output file generated
[22/21121] CXX obj/media/device_monitors/device_monitors/system_message_window_win.obj
ninja: build stopped: subcommand failed.

Did this work before? N/A 

Chrome version: 62.0.3116.0  Channel: canary
OS Version: 10.0
Flash Version: Shockwave Flash 26.0 r0

I am using MSVC 2015 and PGO for my compiles. I have the latest Vulkan SDK installed as well. I have never been able to fully compile with Vulkan enabled.

Comment 1 by ranjitkan@chromium.org, Jul 26 2017

Components: Build
Labels: TE-NeedsTriageHelp

Comment 2 by cblume@chromium.org, Jun 14 2018

Owner: cblume@chromium.org
Status: Fixed (was: Unconfirmed)
This is fixed.
In fact, you don't even need the gn arg enable_vulkan=true any more. Vulkan builds are now part of the default build. You don't need to install the Vulkan SDK either.

Currently, this is only on Linux & X11. I'll be adding more platforms soon (including Windows).

To run with Vulkan you still need to $ out/Default/chrome --enable-vulkan

Comment 3 by devinlam...@gmail.com, Jun 15 2018 

Thanks! Will you need to add additional args to Windows or just use --enable-vulkan in the output?

Comment 4 by cblume@chromium.org, Jul 17 

Sorry for the super late reply.
The answer to your question is a little bit in flux.
In the end, you should only need --enable-vulkan. I think by the time I get around to adding Windows support that is all you will need and the flux will have settled.

Comment 5 by devinlam...@gmail.com, Aug 18 

Thanks for the update - how will I know this is enabled? Just keep trying until enable-vulkan works? :)

Comment 6 by cblume@chromium.org, Aug 20

Blocking: 848388
Oh gosh. Sorry I didn't loop back to you.

I've added a bug that you can follow to see when things are fully in place.

Is there a particular use case you're interested in? A particular platform?
Right now we have a bit of work left in mailboxes / shared images. I can try to go through and update the bug dependencies to reflect that in a bit.

Comment 7 by devinlam...@gmail.com, Aug 20 

I'm looking for mainly Windows/Android - Android to see if offloading to Vulkan makes a difference in latency (ie: jank).

For Windows it's more about tinkering and seeing if using Vulkan leads to any performance improvements in redraw or scrolling.
►

Sign in to add a comment