New issue
Advanced search Search tips

Issue 748524 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

SubresourceFilterSafeBrowsingActivationThrottleParamTest flaky on Win7dbg

Project Member Reported by zakerinasab@chromium.org, Jul 25 2017

Issue description

Starting from https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)/builds/61745, the following tests act flaky on Win7dbg:

ActivationLevelTest/SubresourceFilterSafeBrowsingActivationThrottleParamTest.ListMatchedOnStart_NoDelay/2
ActivationLevelTest/SubresourceFilterSafeBrowsingActivationThrottleParamTest.ListMatchedOnRedirect_NoDelay/1

The suspect culprit is https://chromium.googlesource.com/chromium/src/+/3b979783cc38efd48eeb140d8418eeb119ff314a.

rhalavati@: Would you please take a look at this?
 
Labels: Tests-Disabled
Cc: shivanisha@chromium.org csharrison@chromium.org
 Issue 748529  has been merged into this issue.
Cc: rhalavati@chromium.org
Owner: csharrison@chromium.org
Ramin is OOO, let me own it
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9aa2c74a81d164578e99cf61188b5686161e275d

commit 9aa2c74a81d164578e99cf61188b5686161e275d
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Tue Jul 25 14:45:56 2017

Disable flaky tests on Win7

This CL disables the following unit tests on Win7:

ActivationLevelTest/SubresourceFilterSafeBrowsingActivationThrottleParamTest.ListMatchedOnStart_NoDelay
ActivationLevelTest/SubresourceFilterSafeBrowsingActivationThrottleParamTest.ListMatchedOnRedirect_NoDelay

TBR=rhalavati@chromium.org
NOTRY=true

Bug: 748524
Change-Id: I58b0a1754463389a3ab01a7c53b826da10e0178a
Reviewed-on: https://chromium-review.googlesource.com/585069
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489294}
[modify] https://crrev.com/9aa2c74a81d164578e99cf61188b5686161e275d/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59ae989fc7a5e336d2fd35f283c0d63902bd7dbb

commit 59ae989fc7a5e336d2fd35f283c0d63902bd7dbb
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Tue Jul 25 17:16:51 2017

Disable ActivationLevelTest flaky tests

This CL disables the following unit tests:

ActivationLevelTest/SubresourceFilterSafeBrowsingActivationThrottleParamTest.ListMatchedOnStart_NoDelay
ActivationLevelTest/SubresourceFilterSafeBrowsingActivationThrottleParamTest.ListMatchedOnRedirect_NoDelay

TBR=csharrison@chromium.org
NOTRY=true

Bug: 748524
Change-Id: Ifec74f0d955fca76e91ab9a64744789c77e0fec8
Reviewed-on: https://chromium-review.googlesource.com/584940
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489348}
[modify] https://crrev.com/59ae989fc7a5e336d2fd35f283c0d63902bd7dbb/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52f643096644954e5ddb8eb2b35bafe88c76cdd9

commit 52f643096644954e5ddb8eb2b35bafe88c76cdd9
Author: Alexandre Elias <aelias@chromium.org>
Date: Wed Jul 26 22:23:08 2017

Disable flaky FileLockingTest.UnlockOnTerminate under Android ASAN.

Per guidelines on
https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues,
sheriffs should disable flaky tests when the culprit is not obvious.

TBR=danakj
NOTRY=true
BUG=748524

Change-Id: I9f860def417521b058130e6bf07e999e730ac79c
Reviewed-on: https://chromium-review.googlesource.com/587968
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Commit-Queue: Alexandre Elias <aelias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489776}
[modify] https://crrev.com/52f643096644954e5ddb8eb2b35bafe88c76cdd9/base/files/file_locking_unittest.cc

Sorry I typed the wrong bug for #9, please ignore, that was intended to be http://crbug.com/747518
Labels: Test-Disabled
Adding Test-Disabled label, the Tests>Disabled component is going away.
Cc: linds...@chromium.org
Labels: Hotlist-DisableReview
@csharrison can we just delete these disabled tests since they've been disabled for almost a year?
Components: UI>Browser>AdFilter
Owner: ----
Status: Available (was: Assigned)
This was blocked on some task scheduler work. I think we can fix them. Sorry it fell off my plate.

Sign in to add a comment