New issue
Advanced search Search tips

Issue 748517 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 707375
issue 748242



Sign in to add a comment

sandbox_mac_unittests SandboxMacCompilerV2Test.V2ProfileTest fails on 10.13

Project Member Reported by rsesek@chromium.org, Jul 25 2017

Issue description

Chrome Version: 4b523c1060e2bc62bceb42e3d1674635cd48f2e0
OS: macOS 10.13 High Sierra

What steps will reproduce the problem?
(1) Run sandbox_mac_unittests on 10.13
(2) SandboxMacCompilerV2Test.V2ProfileTest fails

[ RUN      ] SandboxMacCompilerV2Test.V2ProfileTest
[80727:775:0725/020805.455670:23228259291337:WARNING:test_suite.cc(235)] Test launcher output path /b/rr/tmpGfHGOF/t/.org.chromium.Chromium.DMhqrR/test_results.xml exists. Not adding test launcher result printer.
[80727:775:0725/020805.460485:23228263852226:FATAL:sandbox_mac_compiler_v2_unittest.mm(83)] Check failed: zone_file.IsValid(). 
0   sandbox_mac_unittests               0x00000001000cef3c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   sandbox_mac_unittests               0x00000001000da9f0 logging::LogMessage::~LogMessage() + 224
2   sandbox_mac_unittests               0x00000001000a0254 sandbox::V2ProfileProcess() + 1364
3   sandbox_mac_unittests               0x0000000100125f4d base::TestSuite::Run() + 109
4   sandbox_mac_unittests               0x00000001001330eb base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) + 139
5   sandbox_mac_unittests               0x000000010011b499 main + 121
6   libdyld.dylib                       0x00007fffa2f86ff9 start + 1
../../sandbox/mac/sandbox_mac_compiler_v2_unittest.mm:142: Failure
      Expected: exit_code
      Which is: 1
To be equal to: 0
[  FAILED  ] SandboxMacCompilerV2Test.V2ProfileTest (26 ms)


What is the expected result?
Test passes

What happens instead?
Test fails

Please use labels and text to provide additional information.

Job: https://luci-milo.appspot.com/buildbot/chromium.fyi/Chromium%20Mac%2010.13/2
Logs: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_Mac_10.13%2F2%2F%2B%2Frecipes%2Fsteps%2Fsandbox_mac_unittests%2F0%2Fstdout


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/062cd538d212671d84ce62029e9313e362d1877b

commit 062cd538d212671d84ce62029e9313e362d1877b
Author: Greg Kerr <kerrnel@chromium.org>
Date: Tue Jul 25 20:48:05 2017

Fix sandbox_mac_unittests on 10.13.

This resolves a path in the unit test to its realpath, required by the
sandbox profile, and allows metadata access to the filesystem.

Bug:  748517 
Change-Id: Ibb8cb9a46773814abea70623913149635e8ede6b
Reviewed-on: https://chromium-review.googlesource.com/585403
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489419}
[modify] https://crrev.com/062cd538d212671d84ce62029e9313e362d1877b/sandbox/mac/sandbox_mac_compiler_v2_unittest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment