New issue
Advanced search Search tips

Issue 748512 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 748242



Sign in to add a comment

Some gfx_unittests RenderText unittests fail on 10.13

Project Member Reported by rsesek@chromium.org, Jul 25 2017

Issue description

Chrome Version: 4b523c1060e2bc62bceb42e3d1674635cd48f2e0
OS: macOS 10.13 High Sierra

What steps will reproduce the problem?
(1) Run gfx_unittests on 10.13
(2) Observe three test failures related to RenderText: RenderTextHarfBuzzTest.Multiline_HorizontalAlignment_HarfBuzz, RenderTextHarfBuzzTest.Multiline_NormalWidth_HarfBuzz, RenderTextTest.TextDoesntClip_Mac

[ RUN      ] RenderTextHarfBuzzTest.Multiline_NormalWidth/HarfBuzz
../../ui/gfx/render_text_unittest.cc:3071: Failure
      Expected: kTestStrings[i].run_lengths[second_line_start]
      Which is: 7
To be equal to: text_log[second_line_start].glyph_count
      Which is: 8
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3049: kTestStrings[2]
[  FAILED  ] RenderTextHarfBuzzTest.Multiline_NormalWidth/HarfBuzz, where GetParam() = 0 (9 ms)

[ RUN      ] RenderTextHarfBuzzTest.Multiline_HorizontalAlignment/HarfBuzz
../../ui/gfx/render_text_unittest.cc:3229: Failure
      Expected: test_api()->GetAlignmentOffset(0).x() + difference
      Which is: 64
To be equal to: test_api()->GetAlignmentOffset(1).x()
      Which is: 74
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3215: 
../../ui/gfx/render_text_unittest.cc:3229: Failure
      Expected: test_api()->GetAlignmentOffset(0).x() + difference
      Which is: 64
To be equal to: test_api()->GetAlignmentOffset(1).x()
      Which is: 54
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3215: 
[  FAILED  ] RenderTextHarfBuzzTest.Multiline_HorizontalAlignment/HarfBuzz, where GetParam() = 0 (26 ms)

[ RUN      ] RenderTextTest.TextDoesntClip/Mac
../../ui/gfx/render_text_unittest.cc:402: Failure
      Expected: color
      Which is: 4294967295
To be equal to: buffer_color
      Which is: 4293377943
هٔهٔهٔهٔمرحبا at 44, 9
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3930: TextDoesntClip Top Side
../../ui/gfx/render_text_unittest.cc:402: Failure
      Expected: color
      Which is: 4294967295
To be equal to: buffer_color
      Which is: 4281270272
هٔهٔهٔهٔمرحبا at 45, 9
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3930: TextDoesntClip Top Side
../../ui/gfx/render_text_unittest.cc:402: Failure
      Expected: color
      Which is: 4294967295
To be equal to: buffer_color
      Which is: 4283410391
هٔهٔهٔهٔمرحبا at 46, 9
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3930: TextDoesntClip Top Side
../../ui/gfx/render_text_unittest.cc:402: Failure
      Expected: color
      Which is: 4294967295
To be equal to: buffer_color
      Which is: 4293377943
هٔهٔهٔهٔمرحبا at 51, 9
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3930: TextDoesntClip Top Side
../../ui/gfx/render_text_unittest.cc:402: Failure
      Expected: color
      Which is: 4294967295
To be equal to: buffer_color
      Which is: 4281270272
هٔهٔهٔهٔمرحبا at 52, 9
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3930: TextDoesntClip Top Side
../../ui/gfx/render_text_unittest.cc:402: Failure
      Expected: color
      Which is: 4294967295
To be equal to: buffer_color
      Which is: 4283410391
هٔهٔهٔهٔمرحبا at 53, 9
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3930: TextDoesntClip Top Side
../../ui/gfx/render_text_unittest.cc:402: Failure
      Expected: color
      Which is: 4294967295
To be equal to: buffer_color
      Which is: 4293377943
هٔهٔهٔهٔمرحبا at 58, 9
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3930: TextDoesntClip Top Side
../../ui/gfx/render_text_unittest.cc:402: Failure
      Expected: color
      Which is: 4294967295
To be equal to: buffer_color
      Which is: 4281270272
هٔهٔهٔهٔمرحبا at 59, 9
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3930: TextDoesntClip Top Side
../../ui/gfx/render_text_unittest.cc:402: Failure
      Expected: color
      Which is: 4294967295
To be equal to: buffer_color
      Which is: 4283410391
هٔهٔهٔهٔمرحبا at 60, 9
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3930: TextDoesntClip Top Side
[  FAILED  ] RenderTextTest.TextDoesntClip/Mac, where GetParam() = 1 (97 ms)



What is the expected result?
Test passes

What happens instead?
Test fails

Please use labels and text to provide additional information.

Job: https://luci-milo.appspot.com/buildbot/chromium.fyi/Chromium%20Mac%2010.13/2
Logs: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_Mac_10.13%2F2%2F%2B%2Frecipes%2Fsteps%2Fgfx_unittests%2F0%2Fstdout


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Cc: -tapted@chromium.org
Owner: tapted@chromium.org
Status: Assigned (was: Untriaged)
[chrome mac triage] Assigning to tapted@ since he's been working on HarfBuzz. Feel free to reassign or untriage. Thanks!

Comment 2 by tapted@chromium.org, Jul 28 2017

Status: Started (was: Assigned)
These all relate to Arabic text.

Two boil down to "glyphs got fancy" so the tests started failing
 - https://chromium-review.googlesource.com/c/590339/
 - https://chromium-review.googlesource.com/c/590834/


But the third could be a bug.

RenderTextHarfBuzzTest.Multiline_HorizontalAlignment/HarfBuzz

it seems to fail because RenderText::GetDisplayTextDirection(<arabic string>) is saying base::i18n::LEFT_TO_RIGHT when it should be saying RIGHT_TO_LEFT. It still says RIGHT_TO_LEFT for the Hebrew string, but not the Arabic one.

I'm still digging at it -- https://chromium-review.googlesource.com/c/590345/

Comment 3 by tapted@chromium.org, Jul 28 2017

Ah. Nope. The third one is also "Arabic got fancy". Turns out the test was using Arabic numerals which are curiously not-RTL sometimes. Maybe because numerals in Arabic are normally written 1234 rather than ٠١٢٣
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/283f696eb261bed6f50fc39e416f74bbb7d081ca

commit 283f696eb261bed6f50fc39e416f74bbb7d081ca
Author: Trent Apted <tapted@chromium.org>
Date: Mon Jul 31 00:17:42 2017

Fix RenderTextHarfBuzzTest.Multiline_NormalWidth/HarfBuzz on macOS 10.13

One of the characters in the test got fancy causing a wild glyph to
appear. Use a less fancy character.

Bug:  748512 
Change-Id: I22dfcf22f28326b0d9aaeea141d99704c91a8c84
Reviewed-on: https://chromium-review.googlesource.com/590339
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490693}
[modify] https://crrev.com/283f696eb261bed6f50fc39e416f74bbb7d081ca/ui/gfx/render_text_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a3e1a066922389f0ae4892ace98c0b6ae855d96

commit 5a3e1a066922389f0ae4892ace98c0b6ae855d96
Author: Trent Apted <tapted@chromium.org>
Date: Mon Jul 31 00:41:32 2017

Fix RenderTextHarfBuzzTest.Multiline_HorizontalAlignment/HarfBuzz on macOS 10.13

Arabic text rendering got fancy, so the test strings would
no longer create text runs with a matching number of glyphs.

Use a simpler string that just repeats the same character.

Bug:  748512 
Change-Id: Ia1b61d3cf564ffdc9ff22f8406e4072e06e323a4
Reviewed-on: https://chromium-review.googlesource.com/590345
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490694}
[modify] https://crrev.com/5a3e1a066922389f0ae4892ace98c0b6ae855d96/ui/gfx/render_text_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3349f12deb084358410b730ff5e1bf2e5c9cc137

commit 3349f12deb084358410b730ff5e1bf2e5c9cc137
Author: Trent Apted <tapted@chromium.org>
Date: Tue Aug 01 04:31:30 2017

Fix RenderTextTest.TextDoesntClip/Mac on macOS 10.13

This test is rather fragile. One of the quirks on
Windows 8+ now happens on Mac as well.

Bug:  748512 
Change-Id: Id1a2b776a9eea5bb49564ead09a7a0e127f112d0
Reviewed-on: https://chromium-review.googlesource.com/590834
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490848}
[modify] https://crrev.com/3349f12deb084358410b730ff5e1bf2e5c9cc137/ui/gfx/render_text_unittest.cc

Status: Fixed (was: Started)
That should be all of 'em.

Sign in to add a comment