New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 748507 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Jul 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Content Suggestions fake omnibox animation is not correct

Project Member Reported by gambard@chromium.org, Jul 25 2017 
What steps will reproduce the problem?
(1) Open a NTP
(2) Tap the fake omnibox

What is the expected result?
The fake omnibox should become full width at the end of the animation or with a fade in animation.

What happens instead?
The fake omnibox has a full width instantaneously.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9976907bcf629ab0c12902ef11af424cf52f2f92

commit 9976907bcf629ab0c12902ef11af424cf52f2f92
Author: gambard <gambard@chromium.org>
Date: Wed Jul 26 16:55:51 2017

Smooth animation of the fake omnibox moving up

When the fake omnibox is tapped on iPhone, it moves up.
During this move, the width of the omnibox should increase to match the
width of the real omnibox. This increase of width should be done in the
animation time.

Bug:  748507 
Change-Id: I233e56bccc9164c920ce537734dbd94e80523eff
Reviewed-on: https://chromium-review.googlesource.com/586712
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489673}
[modify] https://crrev.com/9976907bcf629ab0c12902ef11af424cf52f2f92/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/9976907bcf629ab0c12902ef11af424cf52f2f92/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h
[modify] https://crrev.com/9976907bcf629ab0c12902ef11af424cf52f2f92/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/9976907bcf629ab0c12902ef11af424cf52f2f92/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Comment 2 by gambard@chromium.org, Jul 27 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment