Hidden items in the context menu focused by keyboard |
|||||||||||
Issue descriptionChrome Version: 62.0.3167.0 Steps To Reproduce: (1) Select an image file in the file list by clicking on thumbnail. See the toolbar turns white. (check-select mode) (2) Click the three-dots button. (3) Type [Up arrow] key several times. Expected Result: The focus of the menu item toggles on the item that is not grayed out. Actual Result: The focus of the menu item sometimes disappears. If you hit [enter], it will trigger the command that is not visible, such as "create new folder".
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/943e158f13877b2ee92dd237913c1b0fa12ace11 commit 943e158f13877b2ee92dd237913c1b0fa12ace11 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Fri Aug 04 03:20:10 2017 Prevent focusing an invisible item in context menu by keyboard. We have been using hidden=true attribute to hide some menu items. We started to use display=none CSS attiribute for the same purpose, so that it can change visibility of items by changing an attribute of the parent node. https://chromium-review.googlesource.com/c/566768/15/ui/file_manager/file_manager/foreground/css/file_manager.css The logic for keyboard focus should also skip items hidden by that way. Bug: 748504 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia4c6cffcc9ac5e64c64da7644622ebf2949727e0 Reviewed-on: https://chromium-review.googlesource.com/597386 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#491926} [modify] https://crrev.com/943e158f13877b2ee92dd237913c1b0fa12ace11/ui/webui/resources/js/cr/ui/menu.js
,
Aug 4 2017
,
Aug 9 2017
This issue is still not fixed, checked on Chrome OS 9824.0.0, 62.0.3176.0 dev build.
,
Aug 10 2017
The fix was merged on Aug.4, and is not yet merged at 62.0.3176.0. Will you confirm with 62.0.3180.0 or newer?
,
Aug 10 2017
,
Aug 10 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 10 2017
Approving merge to M61 Chrome OS.
,
Aug 10 2017
,
Aug 14 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 17 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4b12a7186b9c80ab89371064a15826680d01812 commit b4b12a7186b9c80ab89371064a15826680d01812 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Fri Aug 18 01:27:17 2017 Prevent focusing an invisible item in context menu by keyboard. We have been using hidden=true attribute to hide some menu items. We started to use display=none CSS attiribute for the same purpose, so that it can change visibility of items by changing an attribute of the parent node. https://chromium-review.googlesource.com/c/566768/15/ui/file_manager/file_manager/foreground/css/file_manager.css The logic for keyboard focus should also skip items hidden by that way. TBR=yamaguchi@chromium.org (cherry picked from commit 943e158f13877b2ee92dd237913c1b0fa12ace11) Bug: 748504 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia4c6cffcc9ac5e64c64da7644622ebf2949727e0 Reviewed-on: https://chromium-review.googlesource.com/597386 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491926} Reviewed-on: https://chromium-review.googlesource.com/620330 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#667} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/b4b12a7186b9c80ab89371064a15826680d01812/ui/webui/resources/js/cr/ui/menu.js
,
Nov 8 2017
9901.66.0, 62.0.3202.82 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by yamaguchi@chromium.org
, Jul 25 2017