Swarming UI locks up when typing into filter box for first time |
||
Issue descriptionLoad https://chromium-swarm.appspot.com/tasklist Wait for spinner to stop (this isolates the effect of network requests, but it happens even if you don't wait) In "Search columns" box, start typing "cancel". Observe that after the c is typed, the whole UI locks up for several seconds, and then canc appears in the box and things are fine. The same thing is observed on https://chromium-swarm.appspot.com/botlist This is not observed on staging, so something to do with the dimensions/tags is suspected (there are more on prod than staging)
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/724690621a6eb14791888318cbc4897211a7b892 commit 724690621a6eb14791888318cbc4897211a7b892 Author: Kevin Lubick <kjlubick@google.com> Date: Wed Nov 08 20:24:00 2017 Prevent UI lockup during listing commands This works by simply adding some short circuiting logic to avoid calls to the (somewhat) expensive matchPartCaseInsensitive() for very short queries. Bug: 748502 Change-Id: Ibd9ca46348b1d1d2676fc88569f64c9319b2e9dd Reviewed-on: https://chromium-review.googlesource.com/759118 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Stephan Altmueller <stephana@chromium.org> [modify] https://crrev.com/724690621a6eb14791888318cbc4897211a7b892/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/724690621a6eb14791888318cbc4897211a7b892/appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html
,
Nov 9 2017
The several second lockup is now a brief (100ms) hesitation, which is much more acceptable. |
||
►
Sign in to add a comment |
||
Comment 1 by sheriffbot@chromium.org
, Jul 25 2017