Non-Regression : Focus is seen missing on 'More...' option(Three Dot Menu) in Files App on tabbing second time |
||||||
Issue descriptionChrome Version: 61.0.3163.11/9765.5.0 dev channel Daisy,Kip,Peppy,Quawks & Minnie OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Download image (2)Now go to Files App-> Press 'Tab' button and after it reaches to 'More..' option -> click on it and then context menu is seen -> Now click outside on Files App (3)Again press 'Tab' button until Focus is on 'Sort options' and on next Tab observe Focus is seen Missing on 'Three Dot Menu' but 'More...' Tool tip is seen (Please refer Video and Screenshot ) Expected: After clicking outside and then on pressing 'Tab' button Focus should be seen on 'More...' option Actual: Instead Focus is Missing on 'More...' option This is Non-Regression Issue seen from M-55 @fukino : Please confirm the Issue Note : Issue is seen on latest M-62 build also
,
Jul 25 2017
I have confirmed this also happens on 58.0.3029.140 on Chromebook Pixel 2.
,
Jul 25 2017
I have confirmed this also happens on the "Sort options" and "OPEN" buttons with the same repro steps. So it is likely a common issue with files-toggle-ripple.
,
Jul 26 2017
This doesn't look a Blink's focus implementation issue, but looks a file manager UI issue. Removing Blink>Focus component.
,
Aug 4 2017
Looks relevant to Issue 752035 as those sometimes happen at the same time.
,
Oct 2 2017
I happened to see how this has been happening, while investigating Issue 769297 . https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/menu_button.js?q=using-mouse&sq=package:chromium&l=145 We hide focus by a special attribute attached here to cope with the case "clicking a menu button twice by mouse". It's not restored properly when tabbing.
,
Nov 16 2017
,
Dec 8 2017
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c8e4742010e1aba3984c2ef8335e3906cb0adcc commit 8c8e4742010e1aba3984c2ef8335e3906cb0adcc Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Tue Dec 12 04:11:31 2017 Stop hiding focus ring after losing focus. Users could move focus out of the button without triggering the logic to remove 'using-mouse' class. As a result, the focus ring (highlight) was seen missing when the button got focus again by keyboard navigation. Test: browser_tests --gtest_filter=WebUIResourceBrowserTest.MenuButtonTest* Bug: 748489 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibebe7d5dc1b89dc06490c657e20615e5001af4cc Reviewed-on: https://chromium-review.googlesource.com/814474 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523329} [modify] https://crrev.com/8c8e4742010e1aba3984c2ef8335e3906cb0adcc/chrome/test/data/webui/menu_button_test.html [modify] https://crrev.com/8c8e4742010e1aba3984c2ef8335e3906cb0adcc/ui/webui/resources/js/cr/ui/menu_button.js
,
Dec 12 2017
,
Jul 30
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fukino@chromium.org
, Jul 25 2017Owner: yamaguchi@chromium.org