New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748481 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Leaves the project on 2018/03/02
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature



Sign in to add a comment

Exposing MakeRequestId in ResourceDispatcher

Project Member Reported by hintzed@google.com, Jul 25 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce the problem:
Moving CORS from blink to content/renderer (https://chromium-review.googlesource.com/c/558226/) requires the new CORSURLLoader to be able to conduct a second request when performing a preflight request is required. We need a second unique request id for this request, therefore we need to expose access to the id source in ResourceDispatcher.

What is the expected behavior?

What went wrong?
-

Did this work before? No 

Chrome version: 59.0.3071.115  Channel: stable
OS Version: 
Flash Version:
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d114b2f8fd65dc1ef19355e40de8443c7bc2776

commit 3d114b2f8fd65dc1ef19355e40de8443c7bc2776
Author: Daniel Hintze <hintzed@google.com>
Date: Tue Jul 25 12:53:36 2017

Exposing MakeRequestId in ResourceDispatcher

Moving CORS from blink to content/renderer requires the new
CORSURLLoader to be able to conduct a second request when performing a
preflight request is required. We need a second unique request id for
this request. Since the URLLoaderFactory interface only takes a single
request id, this CL exposes access to the id source in
ResourceDispatcher.

Moving CORS from blink to content/renderer:
(https://chromium-review.googlesource.com/c/558226/)

Bug:  748481 

Change-Id: I6f8d14bdd4051652891e78f6a30465f9ba81fb80
Reviewed-on: https://chromium-review.googlesource.com/584610
Commit-Queue: Daniel Hintze <hintzed@google.com>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489283}
[modify] https://crrev.com/3d114b2f8fd65dc1ef19355e40de8443c7bc2776/content/child/resource_dispatcher.cc
[modify] https://crrev.com/3d114b2f8fd65dc1ef19355e40de8443c7bc2776/content/child/resource_dispatcher.h
[modify] https://crrev.com/3d114b2f8fd65dc1ef19355e40de8443c7bc2776/content/child/resource_dispatcher_unittest.cc

Project Member

Comment 2 by sheriffbot@chromium.org, Jul 25 2017

Labels: Hotlist-Google
Labels: Needs-Milestone

Comment 4 by mkwst@chromium.org, Jul 28 2017

Labels: M-62

Comment 5 by mkwst@chromium.org, Jul 28 2017

Labels: -Needs-Milestone
Cc: hintzed@google.com
Components: Infra>Git
Owner: tyoshino@chromium.org
Status: Assigned (was: Unconfirmed)
tyoshino@: If there is no further update to be done on this issue,please close this issue since fix has been landed.

Thank you!
Components: -Infra>Git Blink>SecurityFeature>CORS Blink>Loader
Status: Fixed (was: Assigned)
Oh, yea. It's been done by the commit by Daniel in the comment 1.

Closing.

Sign in to add a comment