New issue
Advanced search Search tips

Issue 748475 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 748540



Sign in to add a comment

factory: Merge wireless_antenna and wireless_radiotap.

Project Member Reported by hungte@chromium.org, Jul 25 2017

Issue description

We found that there are two tests doing same goal - wireless_antenna and wireless_radiotap.

After checking with Henry, this was introduced by b/35531029. Intel chipsets were not able to perform few commands needed by wireless_antenna, so they made a different implementation - with almost exactly the same input parameters.

Although the way of test was different, but the goal was the same; also in test list it's usually done by a switch of running "ifconfig mlan0", which is pretty bad.

I think we should merge the two tests again, as single "wireless_antenna". The test can have some abstraction of underlying implementations, even using Device API.
 

Comment 1 by hungte@chromium.org, Jul 26 2017

Blocking: 748540

Comment 2 by hungte@chromium.org, Sep 26 2017

Cc: petershih@chromium.org
Owner: chenghan@chromium.org
+chenghan

Although this is RF related, I think merging these two tests can be common refactoring - so I'd assign to chenghan if shen-en hasn't started this.

Shen-en, feel free to change the owner if you already have something done for this.
Nope, not yet started.
chenghan@: Feel free to ask me anything :)
Cc: -petershih@chromium.org
Owner: yhong@chromium.org
Re-assign to yhong since he seem to bump into this issue recently.
Labels: Hotlist-GoodFirstBug
Owner: fshao@chromium.org
This is probably also a good first bug, although it's not very trivial.

Comment 6 by hungte@chromium.org, Today (5 hours ago)

Owner: hmchu@chromium.org
Assign to hmchu as a chance to practice writing pytest

Sign in to add a comment