Issue metadata
Sign in to add a comment
|
Regression: Separator line is seen missing when scale is 1.13 |
||||||||||||||||||||||
Issue descriptionChrome Version:60.0.3112.78 OS:Ubuntu 14.04 URL: https://apps.ubuntu.com/cat/applications/gnome-tweak-tool/ What steps will reproduce the problem? (1)Add above tool >> Open that tool and change scale from fonts section to 1.3 (2)Open chrome, Click on customise and control Google Chrome[3 dot menu beside omnibox] and observe separator lines below zoom and edit fields Expected: Separator lines should not be vanished on changing scale factor. Actual: Instead separator line is seen missing. NOTE:1. Separator line is not missed on changing scale from system settings>>Dispalys 2. Issue is not applicable to Windows This is a regression issue broken in M59. Good Build: 59.0.3047.0 Bad Build: 59.0.3048.0
,
Jul 25 2017
Able to reproduce this issue on Ubuntu 14.04 using chrome latest M60-60.0.3112.78. Using per revision bisect providing bisect results below Bisect Information: -------------------- You are probably looking for a change made after 458262 (known good), but no later than 458263 (first known bad). Change Log URL: ----------------- https://chromium.googlesource.com/chromium/src/+log/34d74089ce961adad864ed974ce27f7bdf270f17..0ff8b19608421be5fa5b53e90c097e4992723b90 thomasanderson@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Jul 25 2017
Adding RB-Stable for this issue, Please feel free to edit if this is not the case.
,
Jul 26 2017
I think blocking stable is a bit drastic for this issue. Lets target a fix for M60 instead. Also, the fix: https://chromium-review.googlesource.com/c/585229/
,
Jul 26 2017
m60 stable is already out.
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99a8dd605c3d49131d90d4f52bc7cdebb6988ca6 commit 99a8dd605c3d49131d90d4f52bc7cdebb6988ca6 Author: Tom Anderson <thomasanderson@chromium.org> Date: Thu Jul 27 22:43:34 2017 GTK: Ensure UPPER_SEPARATORs get drawn when using a fractional scale This CL is a Linux port of the equivalent hack for Windows [1]. [1] https://cs.chromium.org/chromium/src/ui/views/controls/menu/menu_separator.cc?rcl=d1853b975434d1b31a2143fa3a25af48fafda7a0&l=41 BUG= 748473 R=estade@chromium.org Change-Id: I838cb00a147fe9b63dd1a36e1e485fa8f5e0c4a4 Reviewed-on: https://chromium-review.googlesource.com/585229 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#490027} [modify] https://crrev.com/99a8dd605c3d49131d90d4f52bc7cdebb6988ca6/chrome/browser/ui/libgtkui/native_theme_gtk3.cc
,
Jul 27 2017
,
Jul 28 2017
Checked the issue on latest 62.0.3169.0 dev and is working fine.. i.e; Sepearator lines are seen when scale is 1.13
,
Jul 28 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbc38c7c97bcd709d1803eb91b25db9786fa067b commit bbc38c7c97bcd709d1803eb91b25db9786fa067b Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Jul 28 23:08:59 2017 [Merge to M61] GTK: Ensure UPPER_SEPARATORs get drawn when using a fractional scale > This CL is a Linux port of the equivalent hack for Windows [1]. > > [1] https://cs.chromium.org/chromium/src/ui/views/controls/menu/menu_separator.cc?rcl=d1853b975434d1b31a2143fa3a25af48fafda7a0&l=41 > > BUG= 748473 > R=estade@chromium.org > > Change-Id: I838cb00a147fe9b63dd1a36e1e485fa8f5e0c4a4 > Reviewed-on: https://chromium-review.googlesource.com/585229 > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490027} BUG= 748473 TBR=estade@chromium.org NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I5520833e102f1e42ae509e3b8c5cc8f8b4bbc12a Reviewed-on: https://chromium-review.googlesource.com/592084 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#122} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/bbc38c7c97bcd709d1803eb91b25db9786fa067b/chrome/browser/ui/libgtkui/native_theme_gtk3.cc
,
Jul 28 2017
,
Aug 1 2017
Verified the issue on latest 61 i.e;61.0.3163.25 dev and is fixed. Now separator line is seen when scale is 1.13 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sc00335...@techmahindra.com
, Jul 25 2017